Type:
Task
Priority:
Major
Resolution:
Fixed
Table definition hash is protected by pthread rwlock, which doesn't scale very well. Replacing it with lock-free hash solves this bottleneck.
relates to
MDEV-6478
MariaDB on Power8
Closed
links to
{"report":{"fcp":792.3000000715256,"ttfb":272.10000002384186,"pageVisibility":"visible","entityId":49402,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"6731b3fd-a179-44ea-abae-e5f759c0f163","navigationType":0,"readyForUser":856.7000000476837,"redirectCount":0,"resourceLoadedEnd":1032.2000000476837,"resourceLoadedStart":276.7000000476837,"resourceTiming":[{"duration":24.899999976158142,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":276.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":276.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":301.60000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":28.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":277,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":277,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":305.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":112.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":277,"connectEnd":277,"connectStart":277,"domainLookupEnd":277,"domainLookupStart":277,"fetchStart":277,"redirectEnd":0,"redirectStart":0,"requestStart":277,"responseEnd":389.5,"responseStart":389.5,"secureConnectionStart":277},{"duration":219.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":277.10000002384186,"connectEnd":277.10000002384186,"connectStart":277.10000002384186,"domainLookupEnd":277.10000002384186,"domainLookupStart":277.10000002384186,"fetchStart":277.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":277.10000002384186,"responseEnd":496.3000000715256,"responseStart":496.3000000715256,"secureConnectionStart":277.10000002384186},{"duration":222.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":277.2000000476837,"connectEnd":277.2000000476837,"connectStart":277.2000000476837,"domainLookupEnd":277.2000000476837,"domainLookupStart":277.2000000476837,"fetchStart":277.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":277.2000000476837,"responseEnd":499.90000009536743,"responseStart":499.90000009536743,"secureConnectionStart":277.2000000476837},{"duration":222.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":277.40000009536743,"connectEnd":277.40000009536743,"connectStart":277.40000009536743,"domainLookupEnd":277.40000009536743,"domainLookupStart":277.40000009536743,"fetchStart":277.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":277.40000009536743,"responseEnd":500.2000000476837,"responseStart":500.2000000476837,"secureConnectionStart":277.40000009536743},{"duration":223.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":277.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":277.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":501.10000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":223.10000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":277.5,"connectEnd":277.5,"connectStart":277.5,"domainLookupEnd":277.5,"domainLookupStart":277.5,"fetchStart":277.5,"redirectEnd":0,"redirectStart":0,"requestStart":277.5,"responseEnd":500.60000002384186,"responseStart":500.60000002384186,"secureConnectionStart":277.5},{"duration":223.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":277.60000002384186,"connectEnd":277.60000002384186,"connectStart":277.60000002384186,"domainLookupEnd":277.60000002384186,"domainLookupStart":277.60000002384186,"fetchStart":277.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":277.60000002384186,"responseEnd":501,"responseStart":501,"secureConnectionStart":277.60000002384186},{"duration":223.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":277.8000000715256,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":277.8000000715256,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":501.3000000715256,"responseStart":0,"secureConnectionStart":0},{"duration":223.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":277.8000000715256,"connectEnd":277.8000000715256,"connectStart":277.8000000715256,"domainLookupEnd":277.8000000715256,"domainLookupStart":277.8000000715256,"fetchStart":277.8000000715256,"redirectEnd":0,"redirectStart":0,"requestStart":277.8000000715256,"responseEnd":501.60000002384186,"responseStart":501.60000002384186,"secureConnectionStart":277.8000000715256},{"duration":715.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":283.2000000476837,"connectEnd":283.2000000476837,"connectStart":283.2000000476837,"domainLookupEnd":283.2000000476837,"domainLookupStart":283.2000000476837,"fetchStart":283.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":283.2000000476837,"responseEnd":998.9000000953674,"responseStart":998.9000000953674,"secureConnectionStart":283.2000000476837},{"duration":713.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":286.40000009536743,"connectEnd":286.40000009536743,"connectStart":286.40000009536743,"domainLookupEnd":286.40000009536743,"domainLookupStart":286.40000009536743,"fetchStart":286.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":286.40000009536743,"responseEnd":1000,"responseStart":1000,"secureConnectionStart":286.40000009536743},{"duration":460.3000000715256,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":539,"connectEnd":539,"connectStart":539,"domainLookupEnd":539,"domainLookupStart":539,"fetchStart":539,"redirectEnd":0,"redirectStart":0,"requestStart":539,"responseEnd":999.3000000715256,"responseStart":999.3000000715256,"secureConnectionStart":539},{"duration":214.70000004768372,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":786,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":786,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1000.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":28,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1004.2000000476837,"connectEnd":1004.2000000476837,"connectStart":1004.2000000476837,"domainLookupEnd":1004.2000000476837,"domainLookupStart":1004.2000000476837,"fetchStart":1004.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1004.2000000476837,"responseEnd":1032.2000000476837,"responseStart":1032.2000000476837,"secureConnectionStart":1004.2000000476837}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":131,"responseStart":272,"responseEnd":286,"domLoading":275,"domInteractive":1079,"domContentLoadedEventStart":1079,"domContentLoadedEventEnd":1117,"domComplete":1203,"loadEventStart":1203,"loadEventEnd":1204,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1056.9000000953674},{"name":"bigPipe.sidebar-id.end","time":1057.6000000238419},{"name":"bigPipe.activity-panel-pipe-id.start","time":1057.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":1059.2000000476837},{"name":"activityTabFullyLoaded","time":1129.4000000953674}],"measures":[],"correlationId":"880a668fa863c","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":85,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
serg please review patch for this task. At the moment of writing the patch for some reason didn't hit commits@, but it was pushed to bb-power:
commit b2f45ba8280c97f8dc8b1adb3234cf2e28e48982
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Mon Dec 22 19:56:48 2014 +0400
MDEV-7324 - Lock-free hash for table definition cache
commit ea8862aa9ffa1cfac9a99bbe0fe9b539f12b9a19
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Wed Dec 3 13:56:22 2014 +0400
MDEV-6089 - MySQL WL#7305 "Improve MDL scalability by using lock-free hash"
This is prerequisite for MDEV-6089. Added lf_hash_search_using_hash_value(),
which can reuse previously calculated hash value.