Type:
Task
Priority:
Major
Resolution:
Fixed
Table definition hash is protected by pthread rwlock, which doesn't scale very well. Replacing it with lock-free hash solves this bottleneck.
relates to
MDEV-6478
MariaDB on Power8
Closed
links to
{"report":{"fcp":1363,"ttfb":179.59999990463257,"pageVisibility":"visible","entityId":49402,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"c5662a6d-1203-4de2-9090-233ffe4f9324","navigationType":0,"readyForUser":1443.2999999523163,"redirectCount":0,"resourceLoadedEnd":1684.2999999523163,"resourceLoadedStart":188.29999995231628,"resourceTiming":[{"duration":411.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":188.29999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":188.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":599.5,"responseStart":0,"secureConnectionStart":0},{"duration":411.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":188.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":188.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":599.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":649.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":189,"connectEnd":189,"connectStart":189,"domainLookupEnd":189,"domainLookupStart":189,"fetchStart":189,"redirectEnd":0,"redirectStart":0,"requestStart":189,"responseEnd":838.5,"responseStart":838.5,"secureConnectionStart":189},{"duration":812.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":189.59999990463257,"connectEnd":189.59999990463257,"connectStart":189.59999990463257,"domainLookupEnd":189.59999990463257,"domainLookupStart":189.59999990463257,"fetchStart":189.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":189.59999990463257,"responseEnd":1002.1999998092651,"responseStart":1002.1999998092651,"secureConnectionStart":189.59999990463257},{"duration":816.8999998569489,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":189.79999995231628,"connectEnd":189.79999995231628,"connectStart":189.79999995231628,"domainLookupEnd":189.79999995231628,"domainLookupStart":189.79999995231628,"fetchStart":189.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":189.79999995231628,"responseEnd":1006.6999998092651,"responseStart":1006.6999998092651,"secureConnectionStart":189.79999995231628},{"duration":817.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":190,"connectEnd":190,"connectStart":190,"domainLookupEnd":190,"domainLookupStart":190,"fetchStart":190,"redirectEnd":0,"redirectStart":0,"requestStart":190,"responseEnd":1007.1999998092651,"responseStart":1007.1999998092651,"secureConnectionStart":190},{"duration":817.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":190.19999980926514,"connectEnd":190.19999980926514,"connectStart":190.19999980926514,"domainLookupEnd":190.19999980926514,"domainLookupStart":190.19999980926514,"fetchStart":190.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":190.19999980926514,"responseEnd":1007.5999999046326,"responseStart":1007.5999999046326,"secureConnectionStart":190.19999980926514},{"duration":818,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":190.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":190.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1008.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":817.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":190.89999985694885,"connectEnd":190.89999985694885,"connectStart":190.89999985694885,"domainLookupEnd":190.89999985694885,"domainLookupStart":190.89999985694885,"fetchStart":190.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":190.89999985694885,"responseEnd":1008.2999999523163,"responseStart":1008.2999999523163,"secureConnectionStart":190.89999985694885},{"duration":817.8000001907349,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":191.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":191.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1009,"responseStart":0,"secureConnectionStart":0},{"duration":817.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":191.29999995231628,"connectEnd":191.29999995231628,"connectStart":191.29999995231628,"domainLookupEnd":191.29999995231628,"domainLookupStart":191.29999995231628,"fetchStart":191.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":191.29999995231628,"responseEnd":1009.0999999046326,"responseStart":1009.0999999046326,"secureConnectionStart":191.29999995231628},{"duration":918.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":193.29999995231628,"connectEnd":193.29999995231628,"connectStart":193.29999995231628,"domainLookupEnd":193.29999995231628,"domainLookupStart":193.29999995231628,"fetchStart":193.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":193.29999995231628,"responseEnd":1112.0999999046326,"responseStart":1112.0999999046326,"secureConnectionStart":193.29999995231628},{"duration":1462.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":198.39999985694885,"connectEnd":198.39999985694885,"connectStart":198.39999985694885,"domainLookupEnd":198.39999985694885,"domainLookupStart":198.39999985694885,"fetchStart":198.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":198.39999985694885,"responseEnd":1661.0999999046326,"responseStart":1661.0999999046326,"secureConnectionStart":198.39999985694885},{"duration":119.09999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":992.2999999523163,"connectEnd":992.2999999523163,"connectStart":992.2999999523163,"domainLookupEnd":992.2999999523163,"domainLookupStart":992.2999999523163,"fetchStart":992.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":992.2999999523163,"responseEnd":1111.3999998569489,"responseStart":1111.3999998569489,"secureConnectionStart":992.2999999523163},{"duration":379.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1298.8999998569489,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1298.8999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1678.5,"responseStart":0,"secureConnectionStart":0},{"duration":374.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1299.7999999523163,"connectEnd":1299.7999999523163,"connectStart":1299.7999999523163,"domainLookupEnd":1299.7999999523163,"domainLookupStart":1299.7999999523163,"fetchStart":1299.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":1299.7999999523163,"responseEnd":1674.5999999046326,"responseStart":1674.5999999046326,"secureConnectionStart":1299.7999999523163},{"duration":384.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1300.1999998092651,"connectEnd":1300.1999998092651,"connectStart":1300.1999998092651,"domainLookupEnd":1300.1999998092651,"domainLookupStart":1300.1999998092651,"fetchStart":1300.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1300.1999998092651,"responseEnd":1684.2999999523163,"responseStart":1684.2999999523163,"secureConnectionStart":1300.1999998092651}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":35,"responseStart":179,"responseEnd":198,"domLoading":182,"domInteractive":1689,"domContentLoadedEventStart":1689,"domContentLoadedEventEnd":1744,"domComplete":2135,"loadEventStart":2135,"loadEventEnd":2135,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1663.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1664},{"name":"bigPipe.activity-panel-pipe-id.start","time":1664.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1665.7999999523163},{"name":"activityTabFullyLoaded","time":1767}],"measures":[],"correlationId":"34d13e12e06676","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":84,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
serg please review patch for this task. At the moment of writing the patch for some reason didn't hit commits@, but it was pushed to bb-power:
commit b2f45ba8280c97f8dc8b1adb3234cf2e28e48982
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Mon Dec 22 19:56:48 2014 +0400
MDEV-7324 - Lock-free hash for table definition cache
commit ea8862aa9ffa1cfac9a99bbe0fe9b539f12b9a19
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Wed Dec 3 13:56:22 2014 +0400
MDEV-6089 - MySQL WL#7305 "Improve MDL scalability by using lock-free hash"
This is prerequisite for MDEV-6089. Added lf_hash_search_using_hash_value(),
which can reuse previously calculated hash value.