[MDEV-7209] mroonga storage engine fails to build on OpenBSD - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Blocker
Resolution: Fixed
Affects Version/s: 10.5.8
Fix Version/s: 10.2.40, 10.3.31, 10.4.21, 10.5.12, 10.6.4
Component/s: Storage Engine - Mroonga
Labels:
None
Environment:
OpenBSD

Description

The mroonga storage engine fails to build on OpenBSD.

Updating this for 10.5 it is now failing in a different manner.

humpty$ make

===>  Building for mariadb-10.5.8

[1/102] cd /home/ports/pobj/mariadb-10.5.8/build-amd64 && /usr/local/bin/cmake -P /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/cmake/info_src.cmake

[2/102] cd /home/ports/pobj/mariadb-10.5.8/build-amd64 && /usr/local/bin/cmake -P /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/cmake/info_bin.cmake

[3/102] /home/ports/pobj/mariadb-10.5.8/bin/c++  -DDBUG_TRACE -DHAVE_CONFIG_H -DMRN_GROONGA_EMBEDDED -DMRN_GROONGA_NORMALIZER_MYSQL_EMBEDDED -DMYSQL_DYNAMIC_PLUGIN -DWITH_GROONGA_NORMALIZER_MYSQL=1 -Dmroonga_EXPORTS -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-l

ib/include -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-lib/wsrep-API/v26 -Iinclude -Istorage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/lib -I/home/ports/pobj/mariadb

-10.5.8/mariadb-10.5.8/include -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/sql -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/regex -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8 -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/vendor/groonga/incl

ude -O2 -pipe  -I/usr/local/include -fstack-protector --param=ssp-buffer-size=4 -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -fPIC   -std=gnu++11 -MD -MT storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -MF storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o.d -o st

orage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -c /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp

FAILED: storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o

/home/ports/pobj/mariadb-10.5.8/bin/c++  -DDBUG_TRACE -DHAVE_CONFIG_H -DMRN_GROONGA_EMBEDDED -DMRN_GROONGA_NORMALIZER_MYSQL_EMBEDDED -DMYSQL_DYNAMIC_PLUGIN -DWITH_GROONGA_NORMALIZER_MYSQL=1 -Dmroonga_EXPORTS -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-lib/inclu

de -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-lib/wsrep-API/v26 -Iinclude -Istorage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/lib -I/home/ports/pobj/mariadb-10.5.8/

mariadb-10.5.8/include -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/sql -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/regex -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8 -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/vendor/groonga/include -O2

-pipe  -I/usr/local/include -fstack-protector --param=ssp-buffer-size=4 -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -fPIC   -std=gnu++11 -MD -MT storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -MF storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o.d -o storage/mr

oonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -c /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:320:

In file included from /usr/include/c++/v1/math.h:309:

In file included from /usr/include/c++/v1/type_traits:406:

In file included from /usr/include/c++/v1/cstddef:38:

/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id

7.07

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:320:

In file included from /usr/include/c++/v1/math.h:309:

In file included from /usr/include/c++/v1/type_traits:407:

/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id

7.07

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:320:

In file included from /usr/include/c++/v1/math.h:310:

In file included from /usr/include/c++/v1/limits:122:

/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id

7.07

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:1127:

In file included from /usr/include/c++/v1/new:85:

In file included from /usr/include/c++/v1/exception:84:

/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id

7.07

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:1127:

In file included from /usr/include/c++/v1/new:88:

/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id

7.07

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:51:

In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/sql/sql_class.h:23:

In file included from /usr/include/c++/v1/atomic:547:

/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id

7.07

.....

Attachments

Activity

Ascending order - Click to sort in descending order

Brad Smith created issue - 2014-11-26 08:54

Brad Smith made changes - 2014-11-26 08:56

Field	Original Value	New Value
Description	The mroonga storage engine fails to build on OpenBSD. Looking at the code it appears as if netinet/tcp.h is not being included at the bare minimum. The CMake test for netinet/tcp.h is failing. The test needs to include sys/types.h when testing for netinet/tcp.h. /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_send': /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: error: array type has incomplete element type /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: warning: unused variable 'msg_iov' /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen': /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: 'TCP_NODELAY' undeclared (first use in this function) /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: (Each undeclared identifier is reported only once /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: for each function it appears in.) /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen': /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:1063: error: 'TCP_NODELAY' undeclared (first use in this function)	The mroonga storage engine fails to build on OpenBSD. Looking at the code it appears as if netinet/tcp.h is not being included at the bare minimum. The CMake test for netinet/tcp.h is failing. The test needs to include sys/types.h when testing for netinet/tcp.h. {quote} /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_send': /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: error: array type has incomplete element type /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: warning: unused variable 'msg_iov' /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen': /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: 'TCP_NODELAY' undeclared (first use in this function) /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: (Each undeclared identifier is reported only once /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: for each function it appears in.) /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen': /home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:1063: error: 'TCP_NODELAY' undeclared (first use in this function) {quote}

Sergei Golubchik made changes - 2014-11-26 10:23

Assignee

Kentoku [ kentoku ]

Sergei Golubchik made changes - 2014-11-26 10:23

Fix Version/s

10.0.16 [ 17900 ]

Brad Smith made changes - 2014-11-26 11:07

Description

The mroonga storage engine fails to build on OpenBSD.

Looking at the code it appears as if netinet/tcp.h is not being included at the bare minimum. The CMake test for netinet/tcp.h is failing. The test needs to include sys/types.h when testing for netinet/tcp.h.

{quote}
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_send':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: error: array type has incomplete element type
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: warning: unused variable 'msg_iov'
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: 'TCP_NODELAY' undeclared (first use in this function)
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: (Each undeclared identifier is reported only once
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: for each function it appears in.)
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:1063: error: 'TCP_NODELAY' undeclared (first use in this function)
{quote}

The mroonga storage engine fails to build on OpenBSD.

Looking at the code it appears as if netinet/tcp.h is not being included at the bare minimum. The CMake test for netinet/tcp.h is failing. The test needs to include sys/types.h when testing for netinet/tcp.h.

{noformat}
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_send':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: error: array type has incomplete element type
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: warning: unused variable 'msg_iov'
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: 'TCP_NODELAY' undeclared (first use in this function)
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: (Each undeclared identifier is reported only once
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: for each function it appears in.)
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:1063: error: 'TCP_NODELAY' undeclared (first use in this function)
{noformat}

Brad Smith added a comment - 2014-12-08 11:18

Any comment? I can build test any proposed diffs even against a 10.0.15 code base.

Brad Smith added a comment - 2014-12-08 11:18 Any comment? I can build test any proposed diffs even against a 10.0.15 code base.

Brad Smith added a comment - 2014-12-16 16:42

ping.

Brad Smith added a comment - 2014-12-16 16:42 ping.

Brad Smith added a comment - 2015-01-28 02:25

Still broken with 10.0.16.

Brad Smith added a comment - 2015-01-28 02:25 Still broken with 10.0.16.

Sergei Golubchik made changes - 2015-01-28 16:50

Fix Version/s		10.0 [ 16000 ]
Fix Version/s	10.0.16 [ 17900 ]

carrie h added a comment - 2015-02-16 02:18

I'm encountering this exact issue on OpenBSD 5.6 GENERIC.MP#333 amd64 during the initial make for versions 10.0.15 and 10.0.16.

carrie h added a comment - 2015-02-16 02:18 I'm encountering this exact issue on OpenBSD 5.6 GENERIC.MP#333 amd64 during the initial make for versions 10.0.15 and 10.0.16.

Jon Tibble added a comment - 2015-03-29 00:26

This also affects illumos/Solaris based OSs. The following fixed this particular issue for me:

--- mariadb-10.0.17/configure.cmake.~1~ 2015-02-25 15:40:53.000000000 +0000

+++ mariadb-10.0.17/configure.cmake     2015-03-28 19:31:19.075448106 +0000

@@ -196,6 +196,7 @@

 CHECK_INCLUDE_FILES (memory.h HAVE_MEMORY_H)

 CHECK_INCLUDE_FILES (ndir.h HAVE_NDIR_H)

 CHECK_INCLUDE_FILES (netinet/in.h HAVE_NETINET_IN_H)

+CHECK_INCLUDE_FILES ("sys/types.h;netinet/tcp.h" HAVE_NETINET_TCP_H)

 CHECK_INCLUDE_FILES (paths.h HAVE_PATHS_H)

 CHECK_INCLUDE_FILES (port.h HAVE_PORT_H)

 CHECK_INCLUDE_FILES (poll.h HAVE_POLL_H)

Jon Tibble added a comment - 2015-03-29 00:26 This also affects illumos/Solaris based OSs. The following fixed this particular issue for me: --- mariadb-10.0.17/configure.cmake.~1~ 2015-02-25 15:40:53.000000000 +0000 +++ mariadb-10.0.17/configure.cmake 2015-03-28 19:31:19.075448106 +0000 @@ -196,6 +196,7 @@ CHECK_INCLUDE_FILES (memory.h HAVE_MEMORY_H) CHECK_INCLUDE_FILES (ndir.h HAVE_NDIR_H) CHECK_INCLUDE_FILES (netinet/in.h HAVE_NETINET_IN_H) +CHECK_INCLUDE_FILES ("sys/types.h;netinet/tcp.h" HAVE_NETINET_TCP_H) CHECK_INCLUDE_FILES (paths.h HAVE_PATHS_H) CHECK_INCLUDE_FILES (port.h HAVE_PORT_H) CHECK_INCLUDE_FILES (poll.h HAVE_POLL_H)

Kouhei Sutou added a comment - 2015-05-06 11:02

Groonga at master is buildable on OpenBSD. This issue will be fixed when new Groonga is released (It will be released at 2015-05-29) and bundled into MariaDB.

Kouhei Sutou added a comment - 2015-05-06 11:02 Groonga at master is buildable on OpenBSD. This issue will be fixed when new Groonga is released (It will be released at 2015-05-29) and bundled into MariaDB.

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 58729 ]

MariaDB v3 [ 67051 ]

Brad Smith made changes - 2015-08-30 19:05

Affects Version/s		10.0.21 [ 19406 ]
Affects Version/s	10.0.15 [ 17300 ]

Brad Smith added a comment - 2015-08-30 19:08

Building 10.0.21 the issue still exists there. Again the issue is the netinet/tcp.h header check is failing due to the fact that sys/types.h header is not being included at the same time which is required for netinet/tcp.h. The patch Job Tibble posted seems to work but to me it feels like the wrong place to fix the issue. It should be in the Mroonga specific bits of code with regard to the CMake / autoconf infrastructure.

Brad Smith added a comment - 2015-08-30 19:08 Building 10.0.21 the issue still exists there. Again the issue is the netinet/tcp.h header check is failing due to the fact that sys/types.h header is not being included at the same time which is required for netinet/tcp.h. The patch Job Tibble posted seems to work but to me it feels like the wrong place to fix the issue. It should be in the Mroonga specific bits of code with regard to the CMake / autoconf infrastructure.

Kouhei Sutou added a comment - 2015-09-04 17:01

Could you try http://packages.groonga.org/source/mroonga/mariadb-10.0.21-with-mroonga-5.06.tar.gz ?

It replaces bundled Mroonga with the latest Mroonga. If it solves this problem, we can solve this problem by updating bundled Mroonga.

Kouhei Sutou added a comment - 2015-09-04 17:01 Could you try http://packages.groonga.org/source/mroonga/mariadb-10.0.21-with-mroonga-5.06.tar.gz ? It replaces bundled Mroonga with the latest Mroonga. If it solves this problem, we can solve this problem by updating bundled Mroonga.

Brad Smith added a comment - 2016-08-30 00:51 - edited

Since our OpenBSD port has Mroonga disabled (until this is fixed) I forgot about this issue. It still exists with 10.0.27.

/home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen':

/home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:976: error: 'TCP_NODELAY' undeclared (first use in this function)

/home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:976: error: (Each undeclared identifier is reported only once

/home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:976: error: for each function it appears in.)

/home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen':

/home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:1094: error: 'TCP_NODELAY' undeclared (first use in this function)

Brad Smith added a comment - 2016-08-30 00:51 - edited Since our OpenBSD port has Mroonga disabled (until this is fixed) I forgot about this issue. It still exists with 10.0.27. /home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen': /home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:976: error: 'TCP_NODELAY' undeclared (first use in this function) /home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:976: error: (Each undeclared identifier is reported only once /home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:976: error: for each function it appears in.) /home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen': /home/ports/pobj/mariadb-10.0.27/mariadb-10.0.27/storage/mroonga/vendor/groonga/lib/com.c:1094: error: 'TCP_NODELAY' undeclared (first use in this function)

Kouhei Sutou added a comment - 2016-08-30 02:18

Thanks for your report.
I've fixed it as https://github.com/groonga/groonga/commit/ed2045bc1dc985f71af4e290ec460bd2fec96ebe

Mroonga will be able to build on OpenBSD when the latest Groonga and Mroonga are merged into MariaDB.

Kouhei Sutou added a comment - 2016-08-30 02:18 Thanks for your report. I've fixed it as https://github.com/groonga/groonga/commit/ed2045bc1dc985f71af4e290ec460bd2fec96ebe Mroonga will be able to build on OpenBSD when the latest Groonga and Mroonga are merged into MariaDB.

Brad Smith added a comment - 2016-08-30 14:48

Except that did not fix anything. It's a nasty workaround. OpenBSD does have TCP_NODELAY. It is in netinet/tcp.h where it should be. The problem is with the CMake test that is testing for the existence of netinet/tcp.h, the test needs to test sys/types.h + netinet/tcp.h. As Jon pointed out this also affects illumos/Solaris.

Brad Smith added a comment - 2016-08-30 14:48 Except that did not fix anything. It's a nasty workaround. OpenBSD does have TCP_NODELAY. It is in netinet/tcp.h where it should be. The problem is with the CMake test that is testing for the existence of netinet/tcp.h, the test needs to test sys/types.h + netinet/tcp.h. As Jon pointed out this also affects illumos/Solaris.

Kouhei Sutou added a comment - 2016-08-30 14:56 - edited

Do you know a document that TCP_NODELAY requires sys/types.h + netinet/tcp.h?

http://man.openbsd.org/OpenBSD-5.9/tcp.4 says only netinet/tcp.h:

> TCP_NODELAY (from <netinet/tcp.h>)

Kouhei Sutou added a comment - 2016-08-30 14:56 - edited Do you know a document that TCP_NODELAY requires sys/types.h + netinet/tcp.h? http://man.openbsd.org/OpenBSD-5.9/tcp.4 says only netinet/tcp.h: > TCP_NODELAY (from <netinet/tcp.h>)

Kouhei Sutou added a comment - 2016-08-30 15:06

MariaDB 10.0.27 still bundles old Mroonga and Groonga.
I hope that they are updated to the latest version.

Kouhei Sutou added a comment - 2016-08-30 15:06 MariaDB 10.0.27 still bundles old Mroonga and Groonga. I hope that they are updated to the latest version.

Brad Smith made changes - 2020-11-15 06:00

Affects Version/s		10.5.8 [ 25023 ]
Affects Version/s	10.0.21 [ 19406 ]

Brad Smith made changes - 2020-11-15 06:02

Description

The mroonga storage engine fails to build on OpenBSD.

Looking at the code it appears as if netinet/tcp.h is not being included at the bare minimum. The CMake test for netinet/tcp.h is failing. The test needs to include sys/types.h when testing for netinet/tcp.h.

{noformat}
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_send':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: error: array type has incomplete element type
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:717: warning: unused variable 'msg_iov'
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_copen':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: 'TCP_NODELAY' undeclared (first use in this function)
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: (Each undeclared identifier is reported only once
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:947: error: for each function it appears in.)
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c: In function 'grn_com_sopen':
/home/ports/pobj/mariadb-10.0.15/mariadb-10.0.15/storage/mroonga/vendor/groonga/lib/com.c:1063: error: 'TCP_NODELAY' undeclared (first use in this function)
{noformat}

The mroonga storage engine fails to build on OpenBSD.

Updating this for 10.5 it is now failing in a different manner.

{noformat}
humpty$ make
===> Building for mariadb-10.5.8
[1/102] cd /home/ports/pobj/mariadb-10.5.8/build-amd64 && /usr/local/bin/cmake -P /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/cmake/info_src.cmake
[2/102] cd /home/ports/pobj/mariadb-10.5.8/build-amd64 && /usr/local/bin/cmake -P /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/cmake/info_bin.cmake
[3/102] /home/ports/pobj/mariadb-10.5.8/bin/c++ -DDBUG_TRACE -DHAVE_CONFIG_H -DMRN_GROONGA_EMBEDDED -DMRN_GROONGA_NORMALIZER_MYSQL_EMBEDDED -DMYSQL_DYNAMIC_PLUGIN -DWITH_GROONGA_NORMALIZER_MYSQL=1 -Dmroonga_EXPORTS -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-l
ib/include -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-lib/wsrep-API/v26 -Iinclude -Istorage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/lib -I/home/ports/pobj/mariadb
-10.5.8/mariadb-10.5.8/include -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/sql -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/regex -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8 -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/vendor/groonga/incl
ude -O2 -pipe -I/usr/local/include -fstack-protector --param=ssp-buffer-size=4 -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -fPIC -std=gnu++11 -MD -MT storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -MF storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o.d -o st
orage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -c /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp
FAILED: storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o
/home/ports/pobj/mariadb-10.5.8/bin/c++ -DDBUG_TRACE -DHAVE_CONFIG_H -DMRN_GROONGA_EMBEDDED -DMRN_GROONGA_NORMALIZER_MYSQL_EMBEDDED -DMYSQL_DYNAMIC_PLUGIN -DWITH_GROONGA_NORMALIZER_MYSQL=1 -Dmroonga_EXPORTS -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-lib/inclu
de -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/wsrep-lib/wsrep-API/v26 -Iinclude -Istorage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/lib -I/home/ports/pobj/mariadb-10.5.8/
mariadb-10.5.8/include -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/sql -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/regex -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8 -I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/vendor/groonga/include -O2
-pipe -I/usr/local/include -fstack-protector --param=ssp-buffer-size=4 -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -fPIC -std=gnu++11 -MD -MT storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -MF storage/mroonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o.d -o storage/mr
oonga/CMakeFiles/mroonga.dir/ha_mroonga.cpp.o -c /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:320:
In file included from /usr/include/c++/v1/math.h:309:
In file included from /usr/include/c++/v1/type_traits:406:
In file included from /usr/include/c++/v1/cstddef:38:
/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id
7.07
^
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:320:
In file included from /usr/include/c++/v1/math.h:309:
In file included from /usr/include/c++/v1/type_traits:407:
/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id
7.07
^
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:320:
In file included from /usr/include/c++/v1/math.h:310:
In file included from /usr/include/c++/v1/limits:122:
/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id
7.07
^
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:1127:
In file included from /usr/include/c++/v1/new:85:
In file included from /usr/include/c++/v1/exception:84:
/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id
7.07
^
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:24:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/include/my_global.h:1127:
In file included from /usr/include/c++/v1/new:88:
/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id
7.07
^
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/ha_mroonga.cpp:23:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/mrn_mysql.h:51:
In file included from /home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/sql/sql_class.h:23:
In file included from /usr/include/c++/v1/atomic:547:
/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga/version:1:1: error: expected unqualified-id
7.07
^
.....
{noformat}

Brad Smith added a comment - 2020-11-16 03:24

I updated the ticket since it is still open but it was based on 10.0 way back in 2016. Now we're using 10.5.

Brad Smith added a comment - 2020-11-16 03:24 I updated the ticket since it is still open but it was based on 10.0 way back in 2016. Now we're using 10.5.

Sergei Golubchik added a comment - 2020-11-19 17:58

komainu8, is it something you would want to look at?

Sergei Golubchik added a comment - 2020-11-19 17:58 komainu8 , is it something you would want to look at?

Sergei Golubchik made changes - 2020-11-19 17:59

Fix Version/s		10.1 [ 16100 ]
Fix Version/s		10.2 [ 14601 ]
Fix Version/s		10.3 [ 22126 ]
Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]

Sergei Golubchik made changes - 2020-11-19 17:59

Fix Version/s	10.0 [ 16000 ]
Fix Version/s	10.1 [ 16100 ]

Horimoto Yasuhiro added a comment - 2020-11-24 06:17 - edited

Probably, this problem is caused by the Mroonga version is old.
So, I think I can't find anything for resolving this problem for now.

So, first of all, we update to the latest the Mroonga that is included in MariaDB.
Next, I hope that I confirm that this problem whither reproduces or not on the latest Mroonga.

Horimoto Yasuhiro added a comment - 2020-11-24 06:17 - edited Probably, this problem is caused by the Mroonga version is old. So, I think I can't find anything for resolving this problem for now. So, first of all, we update to the latest the Mroonga that is included in MariaDB. Next, I hope that I confirm that this problem whither reproduces or not on the latest Mroonga.

Daniel Nachun added a comment - 2021-07-02 07:30 - edited

I'm a Homebrew maintainer and we recently identified the root cause of this problem. ~~Some versions of Clang expect any file called "version" (or "VERSION" on macOS, due to case insensitivity) to have a certain format~~ (a better explanation is that Clang mistakes the version/VERSION files for the "version" header that is part of its standard library). There are currently several files called "version/VERSION" in the include paths of the mroonga plugin which cause this failure. A similar issue was already fixed by ~~MDEV-25543~~ for a different plugin, and we have implemented a temporary fix in https://github.com/Homebrew/homebrew-core/pull/79696, by renaming the offending files, or removing directories which contain them from include paths. This is also related to ~~MDEV-25716~~, which is caused by the same issue. Please follow up if more information is needed to get this resolved.

Daniel Nachun added a comment - 2021-07-02 07:30 - edited I'm a Homebrew maintainer and we recently identified the root cause of this problem. Some versions of Clang expect any file called "version" (or "VERSION" on macOS, due to case insensitivity) to have a certain format (a better explanation is that Clang mistakes the version/VERSION files for the "version" header that is part of its standard library). There are currently several files called "version/VERSION" in the include paths of the mroonga plugin which cause this failure. A similar issue was already fixed by MDEV-25543 for a different plugin, and we have implemented a temporary fix in https://github.com/Homebrew/homebrew-core/pull/79696 , by renaming the offending files, or removing directories which contain them from include paths. This is also related to MDEV-25716 , which is caused by the same issue. Please follow up if more information is needed to get this resolved.

Brad Smith added a comment - 2021-07-03 10:54 - edited

Oh. I see what you're talking about. From the error, looking at /usr/include/c++/v1/cstddef.. which has...

#include <__config>

#include <version>

and there are some header paths added (-I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga) during the build which happen to have files named "version". I was wondering why we had not run into this with libmarias3 but then I noticed it's VERSION there instead of version so we luck out due to case sensitivity.

Brad Smith added a comment - 2021-07-03 10:54 - edited Oh. I see what you're talking about. From the error, looking at /usr/include/c++/v1/cstddef.. which has... #include <__config> #include <version> and there are some header paths added (-I/home/ports/pobj/mariadb-10.5.8/mariadb-10.5.8/storage/mroonga) during the build which happen to have files named "version". I was wondering why we had not run into this with libmarias3 but then I noticed it's VERSION there instead of version so we luck out due to case sensitivity.

Sergei Golubchik made changes - 2021-07-03 13:03

Assignee

Kentoku Shiba [ kentoku ]

Oleksandr Byelkin [ sanja ]

Sergei Golubchik made changes - 2021-07-03 13:03

Priority

Major [ 3 ]

Blocker [ 1 ]

Daniel Nachun added a comment - 2021-07-03 15:53

Actually this is a problem for libmarias3 as well because macOS is not case sensitive, but it was resolved in a commit that hasn't made it into 10.5 yet: https://github.com/mariadb-corporation/libmarias3/commit/c71898f82598.

Daniel Nachun added a comment - 2021-07-03 15:53 Actually this is a problem for libmarias3 as well because macOS is not case sensitive, but it was resolved in a commit that hasn't made it into 10.5 yet: https://github.com/mariadb-corporation/libmarias3/commit/c71898f82598 .

Oleksandr Byelkin made changes - 2021-07-19 12:02

Status

Open [ 1 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2021-07-27 16:45 - edited

commit 4fc25ed235e9a4cd8fddba0f76ec4cb94cf37ea5 (HEAD -> bb-10.2-MDEV-7209, origin/bb-10.2-MDEV-7209)

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Tue Jul 20 14:47:24 2021 +0200

    MDEV-7209 mroonga storage engine fails to build on OpenBSD

    Rename VERSION -> VERSION.txt

Oleksandr Byelkin added a comment - 2021-07-27 16:45 - edited commit 4fc25ed235e9a4cd8fddba0f76ec4cb94cf37ea5 (HEAD -> bb-10.2-MDEV-7209, origin/bb-10.2-MDEV-7209) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Tue Jul 20 14:47:24 2021 +0200 MDEV-7209 mroonga storage engine fails to build on OpenBSD Rename VERSION -> VERSION.txt

Oleksandr Byelkin made changes - 2021-07-27 16:46

Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Golubchik made changes - 2021-07-27 17:21

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Sergei Golubchik made changes - 2021-07-27 22:20

Fix Version/s		10.2.40 [ 26027 ]
Fix Version/s		10.3.31 [ 26028 ]
Fix Version/s		10.4.21 [ 26030 ]
Fix Version/s		10.5.12 [ 26025 ]
Fix Version/s		10.6.4 [ 26033 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Brad Smith added a comment - 2021-08-13 17:36

Thanks. With 10.6.4 out we're now shipping Mroonga with our port / package in -current.

Brad Smith added a comment - 2021-08-13 17:36 Thanks. With 10.6.4 out we're now shipping Mroonga with our port / package in -current.

Sergei Golubchik made changes - 2021-12-06 21:40

Workflow

MariaDB v3 [ 67051 ]

MariaDB v4 [ 148547 ]

People

Assignee:: Sergei Golubchik

Reporter:: Brad Smith

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 2014-11-26 08:54

Updated:: 2021-08-13 17:36

Resolved:: 2021-07-27 22:20

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Activity

People

Dates

Git Integration