Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6633

Remove magic dependencies for InnoDB compression methods

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.0
    • 10.1.3
    • Packaging
    • None

    Description

      Magic dependencies are a not a good thing.
      If a library dependency is required, it should be checked for and error out if the system has it missing.
      If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing.
      From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system.

      Please create options for each compression type if they are able to be disabled.

      Suggestion for cmake option names: WITH_INNODB_{BZIP2,LZMA,LZO,LZ4}

      Attachments

        Activity

          grknight Brian Evans created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Fix Version/s 10.1 [ 16100 ]
          serg Sergei Golubchik made changes -
          Description Magic dependencies are a not a good thing.
          If a library dependency is required, it should be checked for and error out if the system has it missing.
          If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing.
          From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system.

          Please create options for each compression type if they are able to be disabled.

          Suggestion for cmake option names: WITH_INNODB_{BZIP2,LZMA,LZO,LZ4}
          Magic dependencies are a not a good thing.
          If a library dependency is required, it should be checked for and error out if the system has it missing.
          If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing.
          From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system.

          Please create options for each compression type if they are able to be disabled.

          Suggestion for cmake option names: WITH_INNODB_\{BZIP2,LZMA,LZO,LZ4}
          grknight Brian Evans made changes -
          jplindst Jan Lindström (Inactive) made changes -
          Assignee Jan Lindström [ jplindst ]
          jplindst Jan Lindström (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          jplindst Jan Lindström (Inactive) made changes -
          Component/s Packaging [ 10700 ]
          Fix Version/s 10.1.3 [ 18000 ]
          Fix Version/s 10.1 [ 16100 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 52941 ] MariaDB v3 [ 65351 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 65351 ] MariaDB v4 [ 148155 ]

          People

            jplindst Jan Lindström (Inactive)
            grknight Brian Evans
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.