[MDEV-6633] Remove magic dependencies for InnoDB compression methods Created: 2014-08-22  Updated: 2015-02-04  Resolved: 2015-02-04

Status: Closed
Project: MariaDB Server
Component/s: Packaging
Affects Version/s: 10.1.0
Fix Version/s: 10.1.3

Type: Bug Priority: Major
Reporter: Brian Evans Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Attachments: File 20014_all_mariadb-innodb-compression.patch    

 Description   

Magic dependencies are a not a good thing.
If a library dependency is required, it should be checked for and error out if the system has it missing.
If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing.
From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system.

Please create options for each compression type if they are able to be disabled.

Suggestion for cmake option names: WITH_INNODB_{BZIP2,LZMA,LZO,LZ4}



 Comments   
Comment by Brian Evans [ 2014-12-10 ]

Sample patch from Gentoo for two of the options. This is used in our testing overlay before moving to the main tree.

Comment by Jan Lindström (Inactive) [ 2015-02-04 ]

commit 41dc186aa8a5340c78e783a635a95173cc46a697
Author: Jan Lindström <jan.lindstrom@skysql.com>
Date: Wed Feb 4 19:31:16 2015 +0200

MDEV-6633: Remove magic dependencies for InnoDB compression methods

Added options for each compression type that can be disabled i.e.
bzip2, lz4, lzma and lzo.

Generated at Thu Feb 08 07:13:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.