Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.1.0
-
None
Description
Magic dependencies are a not a good thing.
If a library dependency is required, it should be checked for and error out if the system has it missing.
If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing.
From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system.
Please create options for each compression type if they are able to be disabled.
Suggestion for cmake option names: WITH_INNODB_{BZIP2,LZMA,LZO,LZ4}
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 10.1 [ 16100 ] |
| Description |
Magic dependencies are a not a good thing. If a library dependency is required, it should be checked for and error out if the system has it missing. If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing. From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system. Please create options for each compression type if they are able to be disabled. Suggestion for cmake option names: WITH_INNODB_{BZIP2,LZMA,LZO,LZ4} |
Magic dependencies are a not a good thing. If a library dependency is required, it should be checked for and error out if the system has it missing. If it is optional, a cmake option should be made to skip over it if disabled, but error out if enabled and missing. From a package manager's point of view, creating things that are optional if it simply exists becomes an issue if that library is ever removed from the system. Please create options for each compression type if they are able to be disabled. Suggestion for cmake option names: WITH_INNODB_\{BZIP2,LZMA,LZO,LZ4} |
| Attachment | 20014_all_mariadb-innodb-compression.patch [ 36500 ] |
| Assignee | Jan Lindström [ jplindst ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
commit 41dc186aa8a5340c78e783a635a95173cc46a697
Author: Jan Lindström <jan.lindstrom@skysql.com>
Date: Wed Feb 4 19:31:16 2015 +0200
MDEV-6633: Remove magic dependencies for InnoDB compression methods
Added options for each compression type that can be disabled i.e.
bzip2, lz4, lzma and lzo.
| Component/s | Packaging [ 10700 ] | |
| Fix Version/s | 10.1.3 [ 18000 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Workflow | MariaDB v2 [ 52941 ] | MariaDB v3 [ 65351 ] |
| Workflow | MariaDB v3 [ 65351 ] | MariaDB v4 [ 148155 ] |
Sample patch from Gentoo for two of the options. This is used in our testing overlay before moving to the main tree.