Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6485

[PATCH] Hard-coded paths in the source cannot be opt-out

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 10.0.12
    • 10.0.13
    • None
    • None
    • Linux, Fedora

    Description

      When building mariadb into some un-ordinary directory like /opt/rh (chroot in Software Collections; see softwarecollections.org for details), we do not want to read system paths like /etc/my.cnf.

      However, there are several occurrences in the code, where paths are hard-coded in the source and it makes problems to us when building into some chroot, as mentioned above (reading /etc/my.cnf would be wrong, but we specify correct paths using cmake arguments).

      Proposed solutions:
      Either these cases (hard-coded paths) should be able to opt-out (using e.g. -DNO_HARD_PATHS=1) or they should be removed entirely, since there is always a configured value used.

      Another compromise would be to use the hard-coded paths only when the paths are not specified in the cmake call.

      Attachments

        1. mariadb-file-contents.patch
          2 kB
          Honza Horak
        2. mariadb-paths.patch
          5 kB
          Honza Horak

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Sergei Golubchik made transition -
            Open In Progress
            6d 9h 51m 1
            Sergei Golubchik made transition -
            In Progress In Review
            2d 22h 7m 1
            Sergey Vojtovich made transition -
            In Review Stalled
            1d 17h 40m 1
            Sergei Golubchik made transition -
            Stalled Closed
            43m 10s 1

            People

              serg Sergei Golubchik
              hhorak Honza Horak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.