[MDEV-6485] [PATCH] Hard-coded paths in the source cannot be opt-out Created: 2014-07-25  Updated: 2018-08-03  Resolved: 2014-08-05

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 10.0.12
Fix Version/s: 10.0.13

Type: Bug Priority: Minor
Reporter: Honza Horak Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None
Environment:

Linux, Fedora

Attachments: File mariadb-file-contents.patch     File mariadb-paths.patch    
Issue Links:
Problem/Incident
causes MDEV-16879 MariaDB no longer reads /etc/mysql/my... Closed
Relates
relates to MDEV-6526 INFO_SRC and INFO_BIN installed wrong Closed

 Description   

When building mariadb into some un-ordinary directory like /opt/rh (chroot in Software Collections; see softwarecollections.org for details), we do not want to read system paths like /etc/my.cnf.

However, there are several occurrences in the code, where paths are hard-coded in the source and it makes problems to us when building into some chroot, as mentioned above (reading /etc/my.cnf would be wrong, but we specify correct paths using cmake arguments).

Proposed solutions:
Either these cases (hard-coded paths) should be able to opt-out (using e.g. -DNO_HARD_PATHS=1) or they should be removed entirely, since there is always a configured value used.

Another compromise would be to use the hard-coded paths only when the paths are not specified in the cmake call.

 Comments   
Comment by Honza Horak [ 2014-07-25 ]

The attached are two related patches we use in Fedora, not heavily tested yet, but we believe it should work in our use cases.

Ideally I'd like to see those (or similar) changes merged into mariadb upstream, but I can understand some compromise will have to be made to stay compatible and not break working deployments.

Any comments welcome.

Comment by Sergei Golubchik [ 2014-07-31 ]

hhorak, what is the issue with INFO_SRC and INFO_BIN? What "two packaging commandments" do they break in the docs dir?

Comment by Honza Horak [ 2014-08-04 ]

Good point, there is a bit different issue with INFO_SRC and INFO_BIN - multilib install. We have moved those two files into /usr/lib(64) because their content is platform specific, which prevented us from installing ix86 and x86_64 RPM packages on one machine. Moving those files to /usr/lib (and /usr/lib64 on x86_64) solves this, so we needed to add a searching path to the test.

Comment by Sergey Vojtovich [ 2014-08-05 ]

Ok to push!

Generated at Thu Feb 08 07:12:16 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.