Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5850

MySQL Bug#21317: SHOW CREATE DATABASE does not obey to lower_case_table_names

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.0.9
    • 10.0.10
    • None

    Description

      Test case for MySQL "Bug#21317: SHOW CREATE DATABASE does not obey to lower_case_table_names" fails in 10.0.

      Test diff attached. Please try to apply test case as is unless it is applicable.

      Attachments

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-4784 merge test cases from 5.6

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled
          links to

          Web Link SHOW CREATE DATABASE does not obey to lower_case_table_names

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik added a comment -

            I'm not sure the fix is correct and not even what is the bug here. The bug report talks about lower_case_table_names=2, the test case is for lower_case_table_names=1, code change (in 5.6) deals with both. It's not obvious that for lower_case_table_names=1 the letter case should be preserved in SHOW.

            serg Sergei Golubchik added a comment - I'm not sure the fix is correct and not even what is the bug here. The bug report talks about lower_case_table_names=2 , the test case is for lower_case_table_names=1 , code change (in 5.6) deals with both. It's not obvious that for lower_case_table_names=1 the letter case should be preserved in SHOW.
            monty Michael Widenius added a comment -

            lower_case_table_names should work identically for directories as it does for file names.

            This means that the proposed patch is wrong, as for lower_case_table_names=1 the database should be shown in lower case.

            monty Michael Widenius added a comment - lower_case_table_names should work identically for directories as it does for file names. This means that the proposed patch is wrong, as for lower_case_table_names=1 the database should be shown in lower case.
            monty Michael Widenius added a comment -

            Now fixed in my tree. Will merge it to 10.0 ASAP

            monty Michael Widenius added a comment - Now fixed in my tree. Will merge it to 10.0 ASAP
            monty Michael Widenius added a comment -

            Other things fixed by same patch:

            SHOW CREATE DATABASE will now show correct information, even if you have two databases with same characters but mixed case (like foo and FOO).

            SELECT DATABASE() will not convert the database name to lower case if lower_case_table_names=2

            monty Michael Widenius added a comment - Other things fixed by same patch: SHOW CREATE DATABASE will now show correct information, even if you have two databases with same characters but mixed case (like foo and FOO). SELECT DATABASE() will not convert the database name to lower case if lower_case_table_names=2
            monty Michael Widenius added a comment -

            Sergei pushed this into 10.0, but we got some failing test for this, so there is more to fix.
            Will target to enable this for next 10.0 release

            monty Michael Widenius added a comment - Sergei pushed this into 10.0, but we got some failing test for this, so there is more to fix. Will target to enable this for next 10.0 release
            serg Sergei Golubchik added a comment -

            monty, let's create a new issue for whatever new failures you have found.

            serg Sergei Golubchik added a comment - monty , let's create a new issue for whatever new failures you have found.

            People

              monty Michael Widenius
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.