bug21317.patch
|
PartOf |
|||
| is part of | MDEV-4784 | merge test cases from 5.6 | Stalled |
[MDEV-5850] MySQL Bug#21317: SHOW CREATE DATABASE does not obey to lower_case_table_names Created: 2014-03-13 Updated: 2014-03-29 Resolved: 2014-03-29 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Affects Version/s: | 10.0.9 |
| Fix Version/s: | 10.0.10 |
| Type: | Bug | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Michael Widenius |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | upstream | ||
| Attachments: |
bug21317.patch
|
||||||||
| Issue Links: |
|
||||||||
| Description |
|
Test case for MySQL "Bug#21317: SHOW CREATE DATABASE does not obey to lower_case_table_names" fails in 10.0. Test diff attached. Please try to apply test case as is unless it is applicable. |
| Comments |
| Comment by Sergei Golubchik [ 2014-03-20 ] |
|
I'm not sure the fix is correct and not even what is the bug here. The bug report talks about lower_case_table_names=2, the test case is for lower_case_table_names=1, code change (in 5.6) deals with both. It's not obvious that for lower_case_table_names=1 the letter case should be preserved in SHOW. |
| Comment by Michael Widenius [ 2014-03-22 ] |
|
lower_case_table_names should work identically for directories as it does for file names. This means that the proposed patch is wrong, as for lower_case_table_names=1 the database should be shown in lower case. |
| Comment by Michael Widenius [ 2014-03-23 ] |
|
Now fixed in my tree. Will merge it to 10.0 ASAP |
| Comment by Michael Widenius [ 2014-03-23 ] |
|
Other things fixed by same patch: SHOW CREATE DATABASE will now show correct information, even if you have two databases with same characters but mixed case (like foo and FOO). SELECT DATABASE() will not convert the database name to lower case if lower_case_table_names=2 |
| Comment by Michael Widenius [ 2014-03-29 ] |
|
Sergei pushed this into 10.0, but we got some failing test for this, so there is more to fix. |
| Comment by Sergei Golubchik [ 2014-03-29 ] |
|
monty, let's create a new issue for whatever new failures you have found. |