Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5433

select_result::send_error() is unused

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 5.5.34, 10.0.7
    • 10.0.10
    • None

    Description

      select_result::send_error() is not used anywhere. We need to investigate that to understand whether it was intentional (and the method can be removed), or not (and we now have bugs because of that).

      Attachments

        Activity

          monty Michael Widenius added a comment -

          send_error() was only used to send the error message to the end user (with my_error()).
          In allmost all cases this is just a wrapper for my_message()

          It looks like we take care of the error handling in all send_eof() methods and we don't call send_error() anywhere, so it should be safe to remove this method.
          (I did take a quick look at all send_eof() and send_error() methods and don't see any reason why we can't remove it)

          monty Michael Widenius added a comment - send_error() was only used to send the error message to the end user (with my_error()). In allmost all cases this is just a wrapper for my_message() It looks like we take care of the error handling in all send_eof() methods and we don't call send_error() anywhere, so it should be safe to remove this method. (I did take a quick look at all send_eof() and send_error() methods and don't see any reason why we can't remove it)

          People

            serg Sergei Golubchik
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.