[MDEV-5433] select_result::send_error() is unused Created: 2013-12-11  Updated: 2014-03-26  Resolved: 2014-03-26

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 5.5.34, 10.0.7
Fix Version/s: 10.0.10

Type: Bug Priority: Minor
Reporter: Sergei Golubchik Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: upstream


 Description   

select_result::send_error() is not used anywhere. We need to investigate that to understand whether it was intentional (and the method can be removed), or not (and we now have bugs because of that).

 Comments   
Comment by Michael Widenius [ 2014-01-27 ]

send_error() was only used to send the error message to the end user (with my_error()).
In allmost all cases this is just a wrapper for my_message()

It looks like we take care of the error handling in all send_eof() methods and we don't call send_error() anywhere, so it should be safe to remove this method.
(I did take a quick look at all send_eof() and send_error() methods and don't see any reason why we can't remove it)

Generated at Thu Feb 08 07:04:21 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.