May I suggest the merge is done by pulling from or otherwise merging from the lp branch that Andrew showed, rather than grabbing the tarball?
I believe it is important to keep all the revision history.
Thanks
Arjen Lentz
added a comment - May I suggest the merge is done by pulling from or otherwise merging from the lp branch that Andrew showed, rather than grabbing the tarball?
I believe it is important to keep all the revision history.
Thanks
Andrew McDonnell
added a comment - bzr merge proposed through launchpad:
https://code.launchpad.net/~andymc73/maria/10.0-oqgraph3-varchar/+merge/196081
We just reviewed oqgraph revisions and here is our plan:
we will remove Judy from source distribution
we won't merge OS X fix for configure.cmake
we will "bzr rebase" your revisions (alternatives: bzr merge or apply tarball as single patch)
Please let us know if you feel any of the above is terribly wrong.
Sergey Vojtovich
added a comment - Arjen, Andrew, thanks for your request.
We just reviewed oqgraph revisions and here is our plan:
we will remove Judy from source distribution
we won't merge OS X fix for configure.cmake
we will "bzr rebase" your revisions (alternatives: bzr merge or apply tarball as single patch)
Please let us know if you feel any of the above is terribly wrong.
Arjen did mention previously it would be nice to get the development history,
which a rebase, if it applies cleanly, would do (assuming a bzr rebase works
like a git rebase)
Although my personal opinion is might be cleaner to do a bzr merge, maybe the
storage dir then the test suite as separate commits, because I know if I had
git instead of bzr I would have cleaned up the commit history a lot more for
you first.
I know if this was git and I way merging, I would have cleaned up my history
and then done a rebase on top at your end. Not having dealt with bzr a lot
outside of my immediate commit history, I dont know...
Arjen, is the above correct, or did you simply mean the merge linkages?
As for Judy YMMV I havent tested behaviour widely across distributions, and I
dont have access to a recent OSX system
--Andrew
Andrew McDonnell
added a comment - Hi Sergey,
Arjen did mention previously it would be nice to get the development history,
which a rebase, if it applies cleanly, would do (assuming a bzr rebase works
like a git rebase)
Although my personal opinion is might be cleaner to do a bzr merge, maybe the
storage dir then the test suite as separate commits, because I know if I had
git instead of bzr I would have cleaned up the commit history a lot more for
you first.
I know if this was git and I way merging, I would have cleaned up my history
and then done a rebase on top at your end. Not having dealt with bzr a lot
outside of my immediate commit history, I dont know...
Arjen, is the above correct, or did you simply mean the merge linkages?
As for Judy YMMV I havent tested behaviour widely across distributions, and I
dont have access to a recent OSX system
--Andrew
bzr rebase will preserve revision history ad put all your revisions on top of 10.0. The bad thing is that it will also invalidate lp:~andymc73/oqgraph/10.0-oqgraph3-varchar for further merges. If you plan to use this tree for development, it is better to bzr merge, if not (which I believe is the case) bzr rebase is acceptable. Still, it is up to you to choose which way suits your needs best.
As for Judy: if there is absolutely no way to avoid it's inclusion on certain platforms, we'll have to accept it. But for now it is not clear yet.
Sergey Vojtovich
added a comment - Andrew,
bzr rebase will preserve revision history ad put all your revisions on top of 10.0. The bad thing is that it will also invalidate lp:~andymc73/oqgraph/10.0-oqgraph3-varchar for further merges. If you plan to use this tree for development, it is better to bzr merge, if not (which I believe is the case) bzr rebase is acceptable. Still, it is up to you to choose which way suits your needs best.
As for Judy: if there is absolutely no way to avoid it's inclusion on certain platforms, we'll have to accept it. But for now it is not clear yet.
Let's see how the MariaDB build farm deals with all this, and then look at what it might bring up.
Arjen Lentz
added a comment - Awesome Sergey, thanks for all that work!
Let's see how the MariaDB build farm deals with all this, and then look at what it might bring up.
Thanks Arjen! MariaDB build farm is not capable to deal with it yet due to lack of judy on most platforms. Watch MDEV-5432.
Sergey Vojtovich
added a comment - Thanks Arjen! MariaDB build farm is not capable to deal with it yet due to lack of judy on most platforms. Watch MDEV-5432 .
People
Sergey Vojtovich
Andrew McDonnell
Votes:
0Vote for this issue
Watchers:
7Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":1069.2000002861023,"ttfb":245.80000019073486,"pageVisibility":"visible","entityId":26517,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"3add9dea-ab47-4bd3-bb3a-1cc98ea9fe2a","navigationType":0,"readyForUser":1208.2000002861023,"redirectCount":0,"resourceLoadedEnd":767.8000001907349,"resourceLoadedStart":254,"resourceTiming":[{"duration":154.7000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":254,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":254,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":408.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":156,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":254.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":254.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":410.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":380.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":254.5,"connectEnd":254.5,"connectStart":254.5,"domainLookupEnd":254.5,"domainLookupStart":254.5,"fetchStart":254.5,"redirectEnd":0,"redirectStart":0,"requestStart":415.09999990463257,"responseEnd":634.9000000953674,"responseStart":433.5,"secureConnectionStart":254.5},{"duration":513.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":254.7000002861023,"connectEnd":254.7000002861023,"connectStart":254.7000002861023,"domainLookupEnd":254.7000002861023,"domainLookupStart":254.7000002861023,"fetchStart":254.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":414.90000009536743,"responseEnd":767.8000001907349,"responseStart":436.30000019073486,"secureConnectionStart":254.7000002861023},{"duration":191.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":254.80000019073486,"connectEnd":254.80000019073486,"connectStart":254.80000019073486,"domainLookupEnd":254.80000019073486,"domainLookupStart":254.80000019073486,"fetchStart":254.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":417.40000009536743,"responseEnd":446.2000002861023,"responseStart":440.90000009536743,"secureConnectionStart":254.80000019073486},{"duration":191.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":255,"connectEnd":255,"connectStart":255,"domainLookupEnd":255,"domainLookupStart":255,"fetchStart":255,"redirectEnd":0,"redirectStart":0,"requestStart":419,"responseEnd":446.5,"responseStart":441.5,"secureConnectionStart":255},{"duration":192.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":255.2000002861023,"connectEnd":255.2000002861023,"connectStart":255.2000002861023,"domainLookupEnd":255.2000002861023,"domainLookupStart":255.2000002861023,"fetchStart":255.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":419.40000009536743,"responseEnd":447.30000019073486,"responseStart":442.30000019073486,"secureConnectionStart":255.2000002861023},{"duration":160.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":255.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":255.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":416.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":191.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":255.59999990463257,"connectEnd":255.59999990463257,"connectStart":255.59999990463257,"domainLookupEnd":255.59999990463257,"domainLookupStart":255.59999990463257,"fetchStart":255.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":419.90000009536743,"responseEnd":447.5,"responseStart":443.40000009536743,"secureConnectionStart":255.59999990463257},{"duration":161.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":255.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":255.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":417.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":195.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":256,"connectEnd":256,"connectStart":256,"domainLookupEnd":256,"domainLookupStart":256,"fetchStart":256,"redirectEnd":0,"redirectStart":0,"requestStart":421.09999990463257,"responseEnd":451.09999990463257,"responseStart":444.90000009536743,"secureConnectionStart":256},{"duration":495.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":261.59999990463257,"connectEnd":261.59999990463257,"connectStart":261.59999990463257,"domainLookupEnd":261.59999990463257,"domainLookupStart":261.59999990463257,"fetchStart":261.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":484.2000002861023,"responseEnd":757.3000001907349,"responseStart":746.8000001907349,"secureConnectionStart":261.59999990463257},{"duration":497.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":261.7000002861023,"connectEnd":261.7000002861023,"connectStart":261.7000002861023,"domainLookupEnd":261.7000002861023,"domainLookupStart":261.7000002861023,"fetchStart":261.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":538.5,"responseEnd":759.0999999046326,"responseStart":753.0999999046326,"secureConnectionStart":261.7000002861023},{"duration":142.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":811.3000001907349,"connectEnd":811.3000001907349,"connectStart":811.3000001907349,"domainLookupEnd":811.3000001907349,"domainLookupStart":811.3000001907349,"fetchStart":811.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":915.8000001907349,"responseEnd":954,"responseStart":948.3000001907349,"secureConnectionStart":811.3000001907349},{"duration":187.40000009536743,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1062,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1062,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1249.4000000953674,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":79,"responseStart":246,"responseEnd":258,"domLoading":252,"domInteractive":1279,"domContentLoadedEventStart":1279,"domContentLoadedEventEnd":1335,"domComplete":1934,"loadEventStart":1934,"loadEventEnd":1934,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1251.5},{"name":"bigPipe.sidebar-id.end","time":1252.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":1252.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1254.5},{"name":"activityTabFullyLoaded","time":1353.5999999046326}],"measures":[],"correlationId":"b5b7784875a5a8","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":105,"dbReadsTimeInMs":14,"dbConnsTimeInMs":23,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
May I suggest the merge is done by pulling from or otherwise merging from the lp branch that Andrew showed, rather than grabbing the tarball?
I believe it is important to keep all the revision history.
Thanks