Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
None
Description
- fix tests
funcs_1.is_tables(svoj, make sure serg is aware of this patch, comment added)innodb.help_url(svoj)main.filesort_debug (psergey)main.gis(HF)main.innodb_ext_key(Igor)main.innodb_mysql_sync(svoj)main.system_mysql_db_fix40123 (psergey)main.system_mysql_db_fix50030 (psergey)main.system_mysql_db_fix50117 (psergey)maria.maria(svoj)perfschema.relaylog(svoj)rpl.rpl_current_user(psergey, initial investigation)rpl.rpl_gtid_master_promote(psergey, initial investigation)rpl.rpl_temp_table_mix_row(psergey, initial investigation)rpl.rpl_trunc_temp(psergey, initial investigation),MDEV-4816vcol.vcol_blocked_sql_funcs_innodb(sanja)vcol.vcol_column_def_options_innodb(sanja)vcol.vcol_handler_innodb(sanja)vcol.vcol_ins_upd_innodb(sanja)vcol.vcol_keys_innodb(sanja)vcol.vcol_non_stored_columns_innodb(sanja)vcol.vcol_partition_innodb(sanja)vcol.vcol_select_innodb(sanja)vcol.vcol_supported_sql_funcs_innodb(sanja)vcol.vcol_trigger_sp_innodb(sanja)vcol.vcol_view_innodb(sanja)connect.grant(svoj)sql_discovery.simple(svoj)archive.archive(svoj)main.mysqldhelp(svoj)innodb.innodb_mysql(big-test, svoj)parts.partition_alter1_1_innodb(big-test, svoj)parts.partition_alter1_1_2_innodb(big-test, svoj)parts.partition_alter1_2_innodb(big-test, svoj)parts.partition_alter2_1_1_innodb(big-test, svoj)parts.partition_alter2_1_2_innodb(big-test, svoj)parts.partition_alter2_2_1_innodb(big-test, svoj)parts.partition_alter2_2_2_innodb(big-test, svoj)parts.partition_alter4_innodb(big-test, svoj)sys_vars.log_error_func(embedded, svoj)sys_vars.log_error_func2(embedded, svoj)maria.small_blocksize(embedded, svoj)sys_vars.autocommit_func3(embedded, svoj)sys_vars.autocommit_func2(embedded, svoj)sys_vars.autocommit_func4(embedded, svoj)sys_vars.autocommit_func5(embedded, svoj)sys_vars.tx_isolation_func(embedded, svoj)main.pool_of_threads(embedded, svoj)innodb.innodb(embedded, svoj)archive.archive-big(embedded, svoj)parts.part_supported_sql_func_innodb(embedded, svoj)parts.partition_decimal_myisam(embedded, svoj)parts.partition_decimal_innodb(embedded, svoj)main.sum_distinct-big(embedded, svoj)percona.innodb_sys_index(embedded, svoj)percona.percona_flush_contiguous_neighbors(embedded, svoj)fix "check of testcases" failure(svoj)fix archive.archive non-debug failure(svoj)main.partition_open_files_limit(embedded, svoj)innodb.innodb_bug12400341(embedded, svoj)main.partition_cache(embedded, svoj)main.partition_cache_innodb(embedded, svoj)main.partition_cache_myisam(embedded, svoj)main.query_cache(embedded, svoj)funcs_1.is_statistics_mysql_embedded(embedded, svoj)funcs_1.is_table_constraints_mysql_embedded(embedded, svoj)funcs_1.is_tables_mysql_embedded(embedded, svoj)funcs_1.is_columns_mysql_embedded(embedded, svoj)main-test_sql_discovery.plugin(release, svoj)main.plugin(release, svoj)parts.partition_mgm_lc2_innodb(lc fs, svoj)parts.partition_mgm_lc2_archive(lc fs, svoj)parts.partition_mgm_lc2_memory(lc fs, svoj)parts.partition_mgm_lc2_myisam(lc fs, svoj)vcol.vcol_misc(valgrind, bar)funcs_1.is_cml_memory(valgrind, bar)main.ctype_ucs2_def(valgrind, bar)innodb.innodb-ucs2(valgrind, bar)main.mix2_myisam_ucs2(valgrind, bar)main.ctype_uca(valgrind, bar)main.ctype_ucs(valgrind, bar)binlog.binlog_stm_ctype_ucs(valgrind, bar)binlog.binlog_mysqlbinlog_row_myisam(valgrind, bar)binlog.binlog_mysqlbinlog_row(valgrind, bar)binlog.binlog_row_ctype_ucs(valgrind, bar)funcs_1.storedproc(valgrind, Holyfoot)main.gis(valgrind, Holyfoot)
ps_ddl.test(svoj, comment added)test CHECK_METADATAdoesn't seem to do anything, perhaps the test is wrong?
innodb_mysql_sync.test(svoj, comment added)test TDC_RT_REMOVE_NOT_OWN_KEEP_SHAREnow it's the same as TDC_RT_REMOVE_NOT_OWN_AND_MARK_NOT_USABLE
get_table_def_key()start using get_table_def_key() where 5.6 doesby creating get_table_share(TABLE_LIST) and tdc_open_view(TABLE_LIST)
last argument of wait_while_table_is_used() ?(comment added, svoj)simple_rename_or_index_change to use alter_table_manage_keys?remove half-applied "Bug#14521864: MYSQL 5.1 TO 5.5 BUGS PARTITIONING"remove HA_CAN_EXPORTlet extra() fail if cannot be exportedmost engines will not fail, because they support export
what is HA_READ_OUT_OF_SYNC ?(comment added, svoj)remove HA_BLOCK_CONST_TABLEand other remnants of pushed joins (if any)
- move all rsa/auth stuff into a plugin, grrrr!
check create_table_mode for correctnessfix engines(svoj)connect(svoj)sequence(svoj)test_sql_discovery(svoj)spider(svoj)
fix debian/ubuntu packages build failure(svoj)fix debian/ubuntu build failure(svoj)
Attachments
Issue Links
- blocks
-
-
- Closed
-
- includes
-
-
- Closed
-
-
MDEV-4816 rpl.rpl_trunc_temp fails in 10.0-serg
-
- Closed
-
- is blocked by
-
-
- Closed
-
- is part of
-
-
- Closed
-
- relates to
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
Activity
In 10.0 TDC_RT_REMOVE_NOT_OWN is almost unused in favor of TDC_RT_REMOVE_NOT_OWN_AND_MARK_NOT_USABLE.
But technically I failed to understand it's purpose: wait_while_table_is_used() upgrades shared meta-data lock to exclusive and no other thread is permitted to access this table. Why do we need extra protection mechanism in table definition cache?
If TDC_RT_REMOVE_NOT_OWN_AND_MARK_NOT_USABLE serves a purpose indeed, we need to restore it.
CREATE TABLE t1(a INT, b VARCHAR(255));
ALTER TABLE t1 DROP COLUMN b;
Is the above alter good for in-place algorithm?
If it is, what row format shall t1 have (static or dynamic)?
If it is not allowed or (allowed and format is static): remove juggling with HA_OPTION_PACK_RECORD in mysql_create_frm_image().
else: create .frm after we know for sure which algorithm we will be using, disable juggling with copy algorithm.
ps_ddl.test doesn't contain a test case for revision alexander.nozdrin@oracle.com-20111219114211-49pqi0wfs9p4o9yi
Bug#11748352 - 36002: PREPARED STATEMENTS: IF A VIEW USED IN A STATEMENT IS REPLACED, BAD DATA.
Verified that the problem is applicable to our code, test case from the above revision fails, original test case from BUG#36002 fails.
Also verified that with fully applied changeset test cases succeed.
Merge pushed, remaining items will be moved to another post-10.0.4 task.
HA_READ_OUT_OF_SYNC was introduced with the undermentioned revision. Yet the
sole purpose of this flag is to disable RBR updates batching.
Originally it was named HA_STORES_NO_ROWS, which I find applicable to blackhole only.
I suggested two alternatives: HA_EMPTY or HA_READ_OUT_OF_SYNC.
Meaning of HA_EMPTY is the same as HA_STORES_NO_ROWS.
But HA_READ_OUT_OF_SYNC is a bit more generic: the idea is that storage engine doesn't
guarantee that table updates will be [immediately] visible.
E.g. abstract storage engine may consume N rows [on slave], but return single aggregated result row.
HA_READ_OUT_OF_SYNC is applicable to this case as well, whereas HA_STORES_NO_ROWS is
controversial.
revno: 3763 [merge]
committer: Rohit Kalhans <rohit.kalhans@oracle.com>
branch nick: mysql-trunk
timestamp: Wed 2012-05-02 17:34:42 +0530
message:
WL#5597: Using batch operations when there is no index in RBR
CONTEXT
-------
With RBR, if a table has no indexes, the slave does a full table scan for each
row changed (i.e. updated or deleted). This can be extremely time consuming
when there is a high number of rows to be updated.
SOLUTION
---------
When there is a table without a PK or an INDEX, create a temporary in-memory
index (e.g. in-memory hash table) and store the rows to be update in it. Then for
each row in the table, check if the row exists in the hash table. If there is a
match, do the operation, i.e. update or delete.