Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4174

MariaDB 5.5 thread pool code fails to build on OpenBSD / NetBSD / DragonFly

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.29
    • 5.5.30
    • None
    • None
    • OpenBSD

    Description

      The thread pool code within MariaDB 5.5 and other newer/older releases fails to build on OpenBSD / NetBSD / DragonFly, etc. These other *BSD OS's also have kqueue support. The attached patch adds the other *BSD OS's to the #if def's within the code to make the code build.

      Attachments

        Issue Links

          Activity

            Brad,
            Could you check if this patch http://bazaar.launchpad.net/~maria-captains/maria/5.5-wlad/revision/3662 satisfies needs on those platforms . It is basically yours, just that complicate preprocessor expression is replaced with system check (the preprocessor contant check grew a bit too large listing all BSD variants .I have just OSX and FreeBSD, so I do not know if this will 100% work on all others.
            Thanks!

            wlad Vladislav Vaintroub added a comment - Brad, Could you check if this patch http://bazaar.launchpad.net/~maria-captains/maria/5.5-wlad/revision/3662 satisfies needs on those platforms . It is basically yours, just that complicate preprocessor expression is replaced with system check (the preprocessor contant check grew a bit too large listing all BSD variants .I have just OSX and FreeBSD, so I do not know if this will 100% work on all others. Thanks!
            brad0 Brad Smith added a comment -

            Duhh. Of course that is the better approach I will check this out with OpenBSD and get back to you.

            brad0 Brad Smith added a comment - Duhh. Of course that is the better approach I will check this out with OpenBSD and get back to you.
            brad0 Brad Smith added a comment -

            This builds fine.

            Also does it make sense to have the #error directive at the top and one further down? One of them should be good enough and the one near the top is more visible when you first open the file in an editor.

            Thanks.

            brad0 Brad Smith added a comment - This builds fine. Also does it make sense to have the #error directive at the top and one further down? One of them should be good enough and the one near the top is more visible when you first open the file in an editor. Thanks.

            Yes, you're right about #error . I now left just one on top, removed second. Thanks.

            wlad Vladislav Vaintroub added a comment - Yes, you're right about #error . I now left just one on top, removed second. Thanks.

            People

              wlad Vladislav Vaintroub
              brad0 Brad Smith
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.