[MDEV-4174] MariaDB 5.5 thread pool code fails to build on OpenBSD / NetBSD / DragonFly Created: 2013-02-15  Updated: 2013-06-14  Resolved: 2013-02-20

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: 5.5.29
Fix Version/s: 5.5.30

Type: Bug Priority: Major
Reporter: Brad Smith Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None
Environment:

OpenBSD

Attachments: File patch-sql_threadpool_unix_cc    
Issue Links:
Relates
relates to MDEV-20339 FreeBSD VM builder Open

 Description   

The thread pool code within MariaDB 5.5 and other newer/older releases fails to build on OpenBSD / NetBSD / DragonFly, etc. These other *BSD OS's also have kqueue support. The attached patch adds the other *BSD OS's to the #if def's within the code to make the code build.

 Comments   
Comment by Vladislav Vaintroub [ 2013-02-19 ]

Brad,
Could you check if this patch http://bazaar.launchpad.net/~maria-captains/maria/5.5-wlad/revision/3662 satisfies needs on those platforms . It is basically yours, just that complicate preprocessor expression is replaced with system check (the preprocessor contant check grew a bit too large listing all BSD variants .I have just OSX and FreeBSD, so I do not know if this will 100% work on all others.
Thanks!

Comment by Brad Smith [ 2013-02-19 ]

Duhh. Of course that is the better approach I will check this out with OpenBSD and get back to you.

Comment by Brad Smith [ 2013-02-19 ]

This builds fine.

Also does it make sense to have the #error directive at the top and one further down? One of them should be good enough and the one near the top is more visible when you first open the file in an editor.

Thanks.

Comment by Vladislav Vaintroub [ 2013-02-20 ]

Yes, you're right about #error . I now left just one on top, removed second. Thanks.

Generated at Thu Feb 08 06:54:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.