Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39601

maybe-uninitialized compile error in the Connect Storage Engine

    XMLWordPrintable

Details

    • Related to install and upgrade

    Description

      Compiling the Connect Storage Engine fails with:

      [build] storage/connect/filamdbf.cpp: In function '_qryres* DBFColumns(PGLOBAL, PCSZ, PCSZ, PTOS, bool)':
      [build] storage/connect/filamdbf.cpp:355:33: error: 'tfp' may be used uninitialized [-Werror=maybe-uninitialized]
      [build]   355 |                 } else if (fread(tfp, HEADLEN, 1, infile) != 1) {
      [build]       |                            ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      [build] storage/connect/filamdbf.cpp:249:32: note: 'tfp' was declared here
      [build]   249 |         DESCRIPTOR thisfield, *tfp;
      [build]       |                                ^~~
      [build] cc1plus: all warnings being treated as errors
      [build] gmake[2]: *** [storage/connect/CMakeFiles/connect.dir/build.make:247: storage/connect/CMakeFiles/connect.dir/filamdbf.cpp.o] Error 1
      

      and many (too many to list) maybe-uninitialized instances storage/connect/json.cpp.

      It may be that the code is too confusing for a bot; but regardless of whose fault it is, they hinder development and install-from-source nonetheless.
      Not to mention whether it is, indeed, also too confusing for a human.

      Attachments

        Activity

          People

            danblack Daniel Black
            ParadoxV5 Jimmy Hú
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.