Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39583

Replace the slave-side graceful self-KILL with the master-side COM_QUIT handing in Semi-Synchronous Replication

    XMLWordPrintable

Details

    Description

      In a typical client-server connection, including Asynchronous Replication, the client sends a COM_QUIT command to the server as it closes.

      Instead of this signal, a Semi-Synchronous Replica spawns a duplicate connection for the sole purpose of running a KILL original_connection command.
      This implementation is not only inconsistent (a sign of poor design) but also error-prone (see § Issue Links).

      This difference likely originated from the fact that, until MDEV-32551/MDEV-32385, the protocol ACK receiver did not recognize the COM_QUIT signal and errored when encountering one.
      But now that MDEV-32551 pioneers the pre-existing disconnection signal of the base client-server protocol, this master-side handling can replace and remove (if it hasn't already made obsolete) this extraneous and fragile slave self-KILL, including the various bugfixes that try to keep these shambles together.

      Attachments

        Issue Links

          includes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28141 Slave crashes with Packets out of order when connecting to a shutting down master

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-39641 Semi-Sync Replica can KILL a reässigned connection

          • Major - Major loss of function.
          • Open
          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32385 Semi-Sync Ack_Receiver Thread Should Allow COM_QUIT Command

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32551 "Read semi-sync reply magic number error" warnings on master

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-28114 Semi-sync Master ACK Receiver Thread Can Error on COM_QUIT

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36663 Semi-sync Replica Can't Kill Dump Thread When Using SSL

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-37316 Change Replication and other sql/* to use Connector/C

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-39641 Semi-Sync Replica can KILL a reässigned connection

          • Major - Major loss of function.
          • Open
          links to

          Web Link Zulip thread

          Activity

            People

              ParadoxV5 Jimmy Hú
              ParadoxV5 Jimmy Hú
              Jimmy Hú Jimmy Hú
              Brandon Nesterenko Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 2d
                  2d
                  Remaining:
                  Time Spent - 0.25d Remaining Estimate - 1.75d
                  1.75d
                  Logged:
                  Time Spent - 0.25d Remaining Estimate - 1.75d
                  0.25d

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.