Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39531

Redundant opt files were left behind after removing compression tests

    XMLWordPrintable

Details

    Description

      This commit removed have_innodb_xxx.inc files and innodb-page_compression_xxx tests (xxx == lzo, lzma, etc.) from 10.5 and up:

      commit cba13079da5d381faece85d2c797a385f2959869
      Author: Marko Mäkelä
      Date:   Mon Apr 25 10:42:57 2022 +0300
       
          Remove redundant innodb-page_compression_ tests
          
          These were replaced with innodb.innodb_page_compressed
          in commit 35095c458b4c9d4f27afd0c8ee7ce372ace8edd6
      

      Assuming that this change was correct also for 10.7+ where compression providers were introduced, it is incomplete for these versions, as it left .opt files behind:

      $ ls suite/innodb/include/have_innodb_*.opt
      suite/innodb/include/have_innodb_bzip2.opt
      suite/innodb/include/have_innodb_lzo.opt
      suite/innodb/include/have_innodb_lz4.opt
      suite/innodb/include/have_innodb_snappy.opt
      suite/innodb/include/have_innodb_lzma.opt
      

      Attachments

        Activity

          People

            marko Marko Mäkelä
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.