Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-38889

Spider incorrectly calls tmp_disable_binlog which has no effect on subsequent call to ha_write_row

    XMLWordPrintable

Details

    Description

      Reported by monty.

      In multiple places we have the following in the spider code:

      tmp_disable_binlog(thd); /* Do not replicate the low-level changes. */
        error_num = table->file->ha_write_row(table->record[0]);
        reenable_binlog(thd);
      

      This looks wrong as tmp_disable_binlog has no effect on ha_write_row  or ha_update. tmp_disable_binlog only affects statement based replication at this stage, but ha_write_row requires row logging.

      One potential fix is to use TABLE->disable_rowlogging and TABLE->enable_rowlogging, implemented in gtt-monty 5dfa3eefc56763139f317da1505f34e90cd3ada0 (MDEV-38865).

      Attachments

        Issue Links

          Activity

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.