Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-38019

Send ok packet to client earlier

    XMLWordPrintable

Details

    • Hide
      Send ok packet to client earlier for read queries to get higher performance.

      Axel's select benchmarks shows that this has a notable speed improvement:
          1 Thread: 28% TPS speedup
          8 Threads: 23%
          64 Threads 6%
          
      Show
      Send ok packet to client earlier for read queries to get higher performance. Axel's select benchmarks shows that this has a notable speed improvement:     1 Thread: 28% TPS speedup     8 Threads: 23%     64 Threads 6%     

    Description

      Currently the ok packet to a MariaDB server client is sent in dispatch_command() by the call
      thd->protocol->end_statement()

      We can improve the response time between MariaDB server and client by sending the result packet earlier.

      For select queries we could do that in bool select_send::send_eof().
      For update queries we could do that at once the commit has been approved.

      This will improve performance as the client will be able to process the return data earlier
      and send it's next query while the server is doing cleanup of the previous query.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-38589 SELECT unnecessarily waits for InnoDB log write

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-38683 SIGSEGV (dbg), SIGABRT or ER_EMPTY_QUERY when using ROWS EXAMINED with log_output=TABLE

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-38817 innodb.skip_locked_nowait test failing line 185 - SELECT NOWAIT getting ER_LOCK_WAIT_TIMEOUT

          • Critical - Crashes, loss of data, severe memory leak.
          • In Review

          Bug - A problem which impairs or prevents the functions of the product. MDEV-39013 Fix flaky main.tmp_space_usage test

          • Major - Major loss of function.
          • Stalled
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26789 log_write_up_to needs mechanism to prevent stalls of async. waiters

          • Major - Major loss of function.
          • Closed

          Activity

            People

              monty Michael Widenius
              monty Michael Widenius
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.