Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-37996

CMake cleanup: stop overwriting ZLIB_FOUND /ZLIB_LIBRARIES and similar

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • 10.6, 10.11, 11.4, 11.8
    • 10.11, 11.4, 11.8
    • None
    • None

    Description

      Apparently, it breaks when used with vcpkg.
      There are more intelligent ways to handle that now: e.g create MariaDB::zlib library, which points (in sense of cmake ALIAS or INTERFACE library) either to standard ZLIB:ZLIB, or to own compiled zlib, and use it consistently instead of ${ZLIB_LIBRARIES}.
      target_include_directories should be set consistently, and then it will help eliminate multiple ZLIB_INCLUDE_DIRS sprinkled around the code.

      Do the same with OpenSSL , i.e create MariaDB::OpenSSL which points to either OpenSSL or WolfSSL, define it well (so that users pick up correct target_link_libraries and target_include_directories) and use it consistently in the code

      Attachments

        Activity

          People

            wlad Vladislav Vaintroub
            wlad Vladislav Vaintroub
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.