Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-37915

Spider sts and crd bg threads do nothing in tests

    XMLWordPrintable

Details

    Description

      tested at 10.6 5ed869b0d6d4c18692fb7959894a08446dadbbd9.

      If we apply the following diff (the second abort() is probably redundant but we want to make sure it is doing nothing)

      modified   storage/spider/spd_table.cc
      @@ -8785,6 +8785,7 @@ static void *spider_table_bg_sts_crd_action(
             continue;
           }
           share = (SPIDER_SHARE *) thread->queue_first;
      +    abort();
           if (is_sts)
             share->sts_working = TRUE;
           else
      @@ -8830,6 +8831,7 @@ static void *spider_table_bg_sts_crd_action(
                 ("spider search_link_idx=%d", spider->search_link_idx));
               if (spider->search_link_idx >= 0 && conns[spider->search_link_idx])
               {
      +          abort();
                 int result = is_sts ?
       #ifdef WITH_PARTITION_STORAGE_ENGINE
                   spider_get_sts(share, spider->search_link_idx,
      
      

      all spider tests still pass. Find out whether a recent change accidentally caused this, or the bg threads do nothing by design. If it is the latter, then it's probably a good idea to remove them given they can also be a source of concurrency bugs.

      Attachments

        Activity

          People

            ycp Yuchen Pei
            ycp Yuchen Pei
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: