Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-36142

Master & Relay Log Info: expand init_intvar_from_file from atoi to atoll

    XMLWordPrintable

Details

    Description

      MDEV-25674's Master_Retry_Count is an unsigned long, which is larger (in theory and Linux) than the int range of the info-reading API's init_intvar_from_file.

      Its PR currently parses the number from a string itself.
      For consistency and future-proofing, we should expand init_intvar_from_file's limit itself, at least to long long but ideally with an unsigned long long overload as well (as in MySQL's version).

      We must assess if this change impacts other numeric fields.
      It would be a positive impact if a previous field fell for this trap and was reading over-int values truncated or clamped, because that's a bug.

      Attachments

        Activity

          People

            Unassigned Unassigned
            ParadoxV5 Jimmy Hú
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.