Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35850

make HOSTNAME a cmake configure variable

Details

    Description

      As seen in https://github.com/openwrt/packages/blob/master/utils/mariadb/patches/100-fix_hostname.patch and https://github.com/openwrt/packages/blob/master/utils/mariadb/patches/190-replace-hostname-in-mysqld_safe.patch it seems the standard CMakeList.txt defined HOSTNAME=uname -n isn't always what distros want.

      Sets make this something that can be set at compile time.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          danblack Daniel Black added a comment -

          serg https://github.com/MariaDB/server/pull/3765 acceptable?

          danblack Daniel Black added a comment - serg https://github.com/MariaDB/server/pull/3765 acceptable?
          serg Sergei Golubchik added a comment -

          Questionable. You refer to OpenWRT, and link to their patches. But they use different ways of finding a hostname in mysql_install_db and in mysqld_safe. Your commit won't solve their problem.

          Why do they determine hostname differently in different scripts anyway?

          serg Sergei Golubchik added a comment - Questionable. You refer to OpenWRT, and link to their patches. But they use different ways of finding a hostname in mysql_install_db and in mysqld_safe . Your commit won't solve their problem. Why do they determine hostname differently in different scripts anyway?
          danblack Daniel Black added a comment -

          Their maintainer reviewed and approved the PR.

          danblack Daniel Black added a comment - Their maintainer reviewed and approved the PR.

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.