Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35350

Consolidate MTR wait_for_pattern_in_file.inc and SEARCH_WAIT in search_pattern_in_file.inc

    XMLWordPrintable

Details

    • Task
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 10.5.28
    • Tests
    • None

    Description

      There are two scripts in MTR which do the same thing:

      1) wait_for_pattern_in_file.inc (added by MDEV-33551 in 10.6),
      2) The SEARCH_WAIT parameter to search_pattern_in_file.inc (added by MDEV-34753 in 10.11).

      These scripts should be consolidated into one place, and also backported to 10.5 for more available usage and easier future merges.

      I think the SEARCH_WAIT parameter should be preferred, so everything about finding a pattern in a file is consolidated into one place. Note this option likely has to be slightly extended as well to account for MDEV-35109.

      Attachments

        Activity

          People

            bnestere Brandon Nesterenko
            bnestere Brandon Nesterenko
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.