Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35153

backport the MDEV-34716 fix of socket length in mysql.servers

Details

    Description

      Backport the commit
      "2345407b8c29ab16d188eb15b78bff5f63632b7d MDEV-34716 Fix mysql.servers socket max length too short" which was pushed to 11.7. Also, see the test spider.alter_server in that commit for what it is fixing.

      The reason for opening this issue rather than pushing it directly is because a direct backport causes a regression when running mtr --no-reorder rpl.rpl_mysql_upgrade,stmt rpl.rpl_mysqldump_gtid_slave_pos,stmt (see e.g. https://buildbot.mariadb.org/#/builders/369/builds/25168, at 0340a4a6aee bb-10.5-ycp-push):

      worker[01] Using MTR_BUILD_THREAD 300, with reserved ports 19000..19029
      rpl.rpl_mysql_upgrade 'stmt'             [ pass ]   2575
      rpl.rpl_mysqldump_gtid_slave_pos 'stmt'  [ fail ]
              Test ended at 2024-10-15 13:18:56
       
      CURRENT_TEST: rpl.rpl_mysqldump_gtid_slave_pos
      --- /home/ycp/source/mariadb-server/10.5/src/mysql-test/suite/rpl/r/rpl_mysqldump_gtid_slave_pos.result	2024-10-14 17:39:33.249089152 +1100
      +++ /home/ycp/source/mariadb-server/10.5/src/mysql-test/suite/rpl/r/rpl_mysqldump_gtid_slave_pos.reject	2024-10-15 13:18:55.785632591 +1100
      @@ -36,12 +36,7 @@
       include/sync_with_master_gtid.inc
       select * from mysql.gtid_slave_pos;
       domain_id	sub_id	server_id	seq_no
      -0	2	1	1
      -0	3	1	2
      -0	4	1	3
      -0	5	1	4
      -0	6	1	5
      -0	7	1	6
      +0	2	1	6
       select @@global.gtid_slave_pos as "after initial slave got in sync";
       after initial slave got in sync
       0-1-6
       
      Result length mismatch
      

      So it will require a bit more work. I can also confirm that this regression is not present in 11.7 that contains the patch.

      BTW, regarding the magic number, see the glibc manual:

      ‘char sun_path[108]
      This is the file name to use.

      Incomplete: Why is 108 a magic number? RMS suggests making
      this a zero-length array and tweaking the following example to
      use ‘alloca’ to allocate an appropriate amount of storage
      based on the length of the filename.

      Attachments

        Issue Links

          Activity

            ycp Yuchen Pei added a comment - - edited

            Interestingly, the rpl test regression only happens with the 10.5 backport of the commits, not 10.6+, see bb-10.5-mdev-35153-debug 13612464860f6007f2a9ce1a84bc0f444c6b6e7a and bb-10.6-mdev-35153-debug f4bb0429380d252ab4b99349cbbb161c8df89669

            ycp Yuchen Pei added a comment - - edited Interestingly, the rpl test regression only happens with the 10.5 backport of the commits, not 10.6+, see bb-10.5-mdev-35153-debug 13612464860f6007f2a9ce1a84bc0f444c6b6e7a and bb-10.6-mdev-35153-debug f4bb0429380d252ab4b99349cbbb161c8df89669

            See my comment in MDEV-35098 for the explanation of the rpl.rpl_mysqldump_gtid_slave_pos failure, the test case is non-deterministic and will fail at random depending on exactly how many GTIDs were replicated by earlier testcases. Most likely this backport is just an accidental victim of this non-determinism in the test case.

            knielsen Kristian Nielsen added a comment - See my comment in MDEV-35098 for the explanation of the rpl.rpl_mysqldump_gtid_slave_pos failure, the test case is non-deterministic and will fail at random depending on exactly how many GTIDs were replicated by earlier testcases. Most likely this backport is just an accidental victim of this non-determinism in the test case.
            ycp Yuchen Pei added a comment -

            Now that MDEV-35098 has been fixed I can confirm that the rpl test failure no longer occurs. We can proceed with the push of this backport (already approved as part of MDEV-34716 / MDEV-15696)

            ycp Yuchen Pei added a comment - Now that MDEV-35098 has been fixed I can confirm that the rpl test failure no longer occurs. We can proceed with the push of this backport (already approved as part of MDEV-34716 / MDEV-15696 )
            ycp Yuchen Pei added a comment -

            pushed 77c991766330ac995666afe25e5d03cdca6fe004 to 10.5

            ycp Yuchen Pei added a comment - pushed 77c991766330ac995666afe25e5d03cdca6fe004 to 10.5

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.