Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35125

Unnecessary buf_pool.page_hash lookups

    XMLWordPrintable

Details

    Description

      In the function btr_blob_free() there is an unnecessary lookup of buf_pool.page_hash. If we acquired an additional buffer-fix on the page before mtr_t::commit() and released it after acquiring buf_pool.mutex, we would know that the page still exists in the buffer pool and can be attempted to be freed, without having to look it up in buf_pool.page_hash again.

      There could be similar suboptimal patterns elsewhere as well.

      Attachments

        Issue Links

          Activity

            People

              thiru Thirunarayanan Balathandayuthapani
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 2.75h
                  2.75h

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.