Details
-
Bug
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
10.11.9, 11.1.6, 11.2.5, 11.4.3, 11.5.2, 11.6.1
Description
MDEV-33894 included an inadvertent change that causes SET GLOBAL innodb_log_file_size to write incorrect data to the being-resized log file (ib_logfile101). This does not affect the memory mapped log implementation on 64-bit Linux systems (when the log is stored in a mount -o dax file system or in /dev/shm). As far as I can tell, the fix should be this simple:
diff --git a/storage/innobase/log/log0log.cc b/storage/innobase/log/log0log.cc
|
index 93f8db6bfc0..84219dbc830 100644
|
--- a/storage/innobase/log/log0log.cc
|
+++ b/storage/innobase/log/log0log.cc
|
@@ -804,7 +804,7 @@ void log_t::resize_write_buf(size_t length) noexcept
|
}
|
|
ut_a(os_file_write_func(IORequestWrite, "ib_logfile101", resize_log.m_file,
|
- buf, offset, length) == DB_SUCCESS);
|
+ resize_flush_buf, offset, length) == DB_SUCCESS);
|
}
|
|
/** Write buf to ib_logfile0. |
Attachments
Issue Links
- blocks
-
MDEV-34062 mariadb-backup --backup is extremely slow at copying ib_logfile0
- Closed
- causes
-
MDEV-35411 innodb.log_file_size_online occasionally fails
- Closed
- relates to
-
MDEV-33894 MariaDB does unexpected storage read IO for the redo log
- Closed
-
MDEV-34802 Recovery fails to note some log corruption
- Closed
-
MDEV-34875 provide mechanism to monitor the status of dynamic redo log resize operation
- Open