Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34716

Allow arbitrary options in CREATE SERVER

Details

    • New Feature
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 11.7.1
    • Server
    • None

    Description

      The existing syntax for CREATE SERVER:

      CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
          FOREIGN DATA WRAPPER wrapper_name
          OPTIONS (option [, option] ...)
      

      option:
        { HOST character-literal
        | DATABASE character-literal
        | USER character-literal
        | PASSWORD character-literal
        | SOCKET character-literal
        | OWNER character-literal
        | PORT numeric-literal }
      

      With this change we will have:

      option:
        { HOST character-literal
        | DATABASE character-literal
        | USER character-literal
        | PASSWORD character-literal
        | SOCKET character-literal
        | OWNER character-literal
        | PORT numeric-literal
        | PORT quoted-numerical-literal
        | identifier character-literal}
      

      Attachments

        Issue Links

          Activity

            ycp Yuchen Pei created issue -
            ycp Yuchen Pei made changes -
            Field Original Value New Value
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            Fix Version/s 11.7 [ 29815 ]
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei added a comment -

            Currently under review as a part of MDEV-15696

            ycp Yuchen Pei added a comment - Currently under review as a part of MDEV-15696
            ycp Yuchen Pei made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 11.8 [ 29921 ]
            Fix Version/s 11.7 [ 29815 ]
            ycp Yuchen Pei made changes -
            Fix Version/s 11.7 [ 29815 ]
            Fix Version/s 11.8 [ 29921 ]
            ycp Yuchen Pei made changes -
            serg Sergei Golubchik made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Status In Progress [ 3 ] In Testing [ 10301 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Yuchen Pei [ JIRAUSER52627 ] Roel Van de Paar [ roel ]
            Roel Roel Van de Paar made changes -
            Description The existing syntax for CREATE SERVER:

            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }

            With this change we will have:

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
            * | PORT quoted-numerical-literal
              | identifier character-literal*}
            Roel Roel Van de Paar made changes -
            Description The existing syntax for CREATE SERVER:

            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }

            With this change we will have:

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
            * | PORT quoted-numerical-literal
              | identifier character-literal*}
            The existing syntax for CREATE SERVER:
            {noformat}
            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }

            With this change we will have:

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
            * | PORT quoted-numerical-literal
              | identifier character-literal*}
            {noformat}
            Roel Roel Van de Paar made changes -
            Description The existing syntax for CREATE SERVER:
            {noformat}
            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }

            With this change we will have:

            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
            * | PORT quoted-numerical-literal
              | identifier character-literal*}
            {noformat}
            The existing syntax for CREATE SERVER:
            {noformat}
            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)
            {noformat}
            {noformat}
            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }
            {noformat}
            With this change we will have:
            {noformat}
            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
            * | PORT quoted-numerical-literal
              | identifier character-literal*}
            {noformat}
            Roel Roel Van de Paar made changes -
            Description The existing syntax for CREATE SERVER:
            {noformat}
            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)
            {noformat}
            {noformat}
            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }
            {noformat}
            With this change we will have:
            {noformat}
            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
            * | PORT quoted-numerical-literal
              | identifier character-literal*}
            {noformat}
            The existing syntax for CREATE SERVER:
            {noformat}
            CREATE [OR REPLACE] SERVER [IF NOT EXISTS] server_name
                FOREIGN DATA WRAPPER wrapper_name
                OPTIONS (option [, option] ...)
            {noformat}
            {noformat}
            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal }
            {noformat}
            With this change we will have:
            {noformat}
            option:
              { HOST character-literal
              | DATABASE character-literal
              | USER character-literal
              | PASSWORD character-literal
              | SOCKET character-literal
              | OWNER character-literal
              | PORT numeric-literal
              | PORT quoted-numerical-literal
              | identifier character-literal}
            {noformat}
            Roel Roel Van de Paar made changes -

            Testing was included with MDEV-15696

            OK to push

            Roel Roel Van de Paar added a comment - Testing was included with MDEV-15696 OK to push
            Roel Roel Van de Paar made changes -
            Assignee Roel Van de Paar [ roel ] Yuchen Pei [ JIRAUSER52627 ]
            Status In Testing [ 10301 ] Stalled [ 10000 ]
            ycp Yuchen Pei added a comment -

            thanks for the testing Roel. Pushed as part of MDEV-15696.

            As mentioned in https://jira.mariadb.org/browse/MDEV-15696?focusedCommentId=289669&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-289669, the two cleanup and bugfix commits (see below) will also be pushed to the earliest version applicable

            2345407b8c2 MDEV-34716 Fix mysql.servers socket max length too short
            84df8d72751 MDEV-34716 spider: some trivial cleanups and documentation
            

            ycp Yuchen Pei added a comment - thanks for the testing Roel . Pushed as part of MDEV-15696 . As mentioned in https://jira.mariadb.org/browse/MDEV-15696?focusedCommentId=289669&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-289669 , the two cleanup and bugfix commits (see below) will also be pushed to the earliest version applicable 2345407b8c2 MDEV-34716 Fix mysql.servers socket max length too short 84df8d72751 MDEV-34716 spider: some trivial cleanups and documentation
            ycp Yuchen Pei made changes -
            Fix Version/s 11.7.1 [ 29913 ]
            Fix Version/s 11.7 [ 29815 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            ycp Yuchen Pei made changes -
            serg Sergei Golubchik made changes -
            Issue Type Task [ 3 ] New Feature [ 2 ]
            ycp Yuchen Pei made changes -
            elenst Elena Stepanova made changes -

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.