Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
Description
Unfortunately, CREATE SERVER does not yet support ODBC Connection Keywords (aka parameters) in its OPTIONS clause. For example, this statement does not yet work:
CREATE SERVER mssql_hq_server |
FOREIGN DATA WRAPPER odbc |
OPTIONS (
|
DSN 'Legacy-MSSQL-Server', |
UID 'mssql_user', |
PWD 'password', |
);
|
This currently results in a syntax error:
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DSN 'Legacy-MSSQL-Server',
|
UID 'mssql_user',
|
PWD 'password',
|
)' at line 4
|
The standard only defines a handful universal keywords, and the remaining is left to each driver to decide. So instead of defining allowed keywords and validating their values, we should simply accept them and construct the odbc connection string using these key-value pairs.
Attachments
Issue Links
- relates to
-
MDEV-33925 Add TLS-related options for CREATE SERVER
-
- Open
-
- split to
-
-
- Closed
-
Activity
Looks like I'll have to withdraw the patch and work out MDEV-15696 first.
A few tests fail, of which the test main.mysqldump-system is non-trivial, as it dumps a server created with CREATE SERVER s1 FOREIGN DATA WRAPPER mysql OPTIONS(Host 'localhost'); into CREATE SERVER s1 FOREIGN DATA WRAPPER mysql OPTIONS (Host 'localhost', Port 3306, Options {"Host": "localhost"});
The problem lies in dump_all_servers() in mysqldump.cc, which reads each field as a client and print them out in OPTIONS.
We could parse JSON in mysqldump.cc, but it will introduce complexity and it seems to me that it would be better to just implement SHOW CREATE SERVER, which is MDEV-15696.
holyfoot, ralf.gebhardt, serg, let me know if you have any thoughts on this.
Hi holyfoot, ptal thanks (in the branch 11.4-enterprise-ment-796):
# the CS spider part of the main implementation of MENT-796beacfcbeac9 MDEV-34272 create server with odbc results in connection string# the sql layer implementation of MENT-796e318fc9c45d MDEV-34272 Allow arbitrary options in CREATE SERVER# fixes an independent SERVER bugf7218cafe1c MDEV-34272 Fix mysql.servers socket max length too short# just some independent cleanups, should be backported to the earliest possible versionea1249e5abe MDEV-34272 spider: some trivial cleanups and documentationalso applied to CS (in bb-11.4-mdev-34272) as
d2eb785f3e9 upstream/bb-11.4-mdev-34272 MDEV-34272 create server with odbc results in connection stringcef6d3e0d12 MDEV-34272 Allow arbitrary options in CREATE SERVER3e87ba578bd MDEV-34272 Fix mysql.servers socket max length too shorte6234e3eec9 MDEV-34272 spider: some trivial cleanups and documentation