Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34494

Add server_uid global variable and add it to error log at startup

Details

    Description

      Add server_uid global variable and add it to error log to allow one to verify if error reports are from the same server.

      The server_uid variable should use the same unique identifier created by the feedback plugin. This uses a combination of port and mac address to create the id.

      Attachments

        Issue Links

          Activity

            danblack Daniel Black added a comment -

            Can you take the uuid out of the aria control file so that its portable if the hardware changes?

            danblack Daniel Black added a comment - Can you take the uuid out of the aria control file so that its portable if the hardware changes?

            it's a tradeoff. if you store it in a datadir, it'll be included in whatever datadir clone when one bootstraps new slaves.
            if it's tied to a hardware — it changes when hardware changes.
            it can be in /etc too, also can be copied unintentionally, but at least won't be automatically part of a backup or a clone.
            inode of something — resistant to some of hardware changes, still much more fragile.

            serg Sergei Golubchik added a comment - it's a tradeoff. if you store it in a datadir, it'll be included in whatever datadir clone when one bootstraps new slaves. if it's tied to a hardware — it changes when hardware changes. it can be in /etc too, also can be copied unintentionally, but at least won't be automatically part of a backup or a clone. inode of something — resistant to some of hardware changes, still much more fragile.

            The uuid in Aria is not tied to hardware. It is resilient to hardware and server change as it is only tied to data. If data is coped with the control file, as maria_backup is doing, things will 'just' work.

            monty Michael Widenius added a comment - The uuid in Aria is not tied to hardware. It is resilient to hardware and server change as it is only tied to data. If data is coped with the control file, as maria_backup is doing, things will 'just' work.

            Pushed to 10.5 branch

            monty Michael Widenius added a comment - Pushed to 10.5 branch
            danblack Daniel Black added a comment -

            sql_print_error("feedback plugin: failed to retrieve the MAC address"); is now the wrong message.

            danblack Daniel Black added a comment - sql_print_error("feedback plugin: failed to retrieve the MAC address"); is now the wrong message.

            MDEV-34733 is potentially a regression of this change.

            otto Otto Kekäläinen added a comment - MDEV-34733 is potentially a regression of this change.

            People

              monty Michael Widenius
              monty Michael Widenius
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.