Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33746

macOS virtual override markings missing

Details

    Description

      clang on macOS complains about the lack of override markings for virtual override methods, one such example (of many):

      /Users/dgosselin/10.5/server/sql/../storage/myisam/ha_myisam.h:163:7: warning: 'multi_range_read_next' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      		 
        int multi_range_read_next(range_id_t *range_info);

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-34185 macOS Build & Test

          • Major - Major loss of function.
          • Open

          Activity

            Transition Time In Source Status Execution Times
            Dave Gosselin made transition -
            Open In Progress
            		83d 2h 12m 1
            Dave Gosselin made transition -
            Stalled In Review
            		9h 33m 1
            Dave Gosselin made transition -
            In Progress In Review
            		22h 36m 2
            Marko Mäkelä made transition -
            In Review Stalled
            		3d 7h 35m 3
            Dave Gosselin made transition -
            Stalled In Progress
            		3d 7h 33m 2
            Dave Gosselin made transition -
            In Progress Closed
            		18s 1

            People

              Gosselin Dave Gosselin
              Gosselin Dave Gosselin
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.