Type:
Priority:
Resolution:
Fixed
Affects Version/s:
10.5
This was found as part of MDEV-33478 MDEV-33478
This is fairly old code, why did new MSAN find it while valgrind didn't? It seems the cause was that the value was copied between Item objects but was not used.
If I add a printout:
diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc
index f8fd28aebb5..7ec7a752875 100644
--- a/sql/item_cmpfunc.cc
+++ b/sql/item_cmpfunc.cc
@@ -5076,6 +5076,7 @@ Item_cond::fix_fields(THD *thd, Item **ref)
with_flags|= item->with_flags;
}
(void) eval_not_null_tables((void*) 0);
+ fprintf(stderr, "AAQ: not_null_tables_cache=%llx\n", not_null_tables_cache);
/*
We have to set fixed as some other items will check it and fail if we
the attached testcase (extract from include/common-tests.inc) starts to fail under valgrind:
==23601== Thread 6:
==23601== Use of uninitialised value of size 8
==23601== at 0x747F7E1: _itoa_word (_itoa.c:180)
==23601== by 0x7482EDD: vfprintf (vfprintf.c:1642)
==23601== by 0x748563F: buffered_vfprintf (vfprintf.c:2329)
==23601== by 0x74826F5: vfprintf (vfprintf.c:1301)
==23601== by 0x748BE13: fprintf (fprintf.c:32)
==23601== by 0xE9C878: Item_cond::fix_fields(THD*, Item**) (item_cmpfunc.cc:5079)
==23601== by 0xB18FC8: make_cond_for_table_from_pred(THD*, Item*, Item*, unsigned long long, unsigned long long, int, bool, bool, bool) (sql_select.cc:23938)
==23601== by 0xB18CBC: make_cond_for_table(THD*, Item*, unsigned long long, unsigned long long, int, bool, bool) (sql_select.cc:23869)
==23601== by 0xAFA17A: make_join_select(JOIN*, SQL_SELECT*, Item*) (sql_select.cc:12543)
==23601== by 0xADC64D: JOIN::optimize_stage2() (sql_select.cc:2855)
==23601== by 0xADB459: JOIN::optimize_inner() (sql_select.cc:2590)
==23601== by 0xAD8A6D: JOIN::optimize() (sql_select.cc:1888)
==23601== by 0xAE4A58: mysql_select(THD*, TABLE_LIST*, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) (sql_select.cc:5127)
==23601== by 0xAD3452: handle_select(THD*, LEX*, select_result*, unsigned long) (sql_select.cc:559)
==23601== by 0xA91440: execute_sqlcom_select(THD*, TABLE_LIST*) (sql_parse.cc:6372)
is part of
MDEV-33478
Tests massively fail with clang-18 -fsanitize=memory
Closed
{"report":{"fcp":2025.6000001430511,"ttfb":521.2999999523163,"pageVisibility":"visible","entityId":128348,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"1ae3967e-87ae-4de1-8ed4-ffcefd5f0ef8","navigationType":0,"readyForUser":2155,"redirectCount":0,"resourceLoadedEnd":2342.9000000953674,"resourceLoadedStart":526.6000001430511,"resourceTiming":[{"duration":864.0999999046326,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":526.6000001430511,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":526.6000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1390.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":864.0999999046326,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":526.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":526.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1391,"responseStart":0,"secureConnectionStart":0},{"duration":925.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":527.1000001430511,"connectEnd":527.1000001430511,"connectStart":527.1000001430511,"domainLookupEnd":527.1000001430511,"domainLookupStart":527.1000001430511,"fetchStart":527.1000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":527.1000001430511,"responseEnd":1452.9000000953674,"responseStart":1452.9000000953674,"secureConnectionStart":527.1000001430511},{"duration":1074.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":527.2999999523163,"connectEnd":527.2999999523163,"connectStart":527.2999999523163,"domainLookupEnd":527.2999999523163,"domainLookupStart":527.2999999523163,"fetchStart":527.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":527.2999999523163,"responseEnd":1602.2000000476837,"responseStart":1602.2000000476837,"secureConnectionStart":527.2999999523163},{"duration":1078.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":527.4000000953674,"connectEnd":527.4000000953674,"connectStart":527.4000000953674,"domainLookupEnd":527.4000000953674,"domainLookupStart":527.4000000953674,"fetchStart":527.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":527.4000000953674,"responseEnd":1606.2000000476837,"responseStart":1606.2000000476837,"secureConnectionStart":527.4000000953674},{"duration":1079.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":527.7000000476837,"connectEnd":527.7000000476837,"connectStart":527.7000000476837,"domainLookupEnd":527.7000000476837,"domainLookupStart":527.7000000476837,"fetchStart":527.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":527.7000000476837,"responseEnd":1607.2000000476837,"responseStart":1607.2000000476837,"secureConnectionStart":527.7000000476837},{"duration":1079.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":527.7999999523163,"connectEnd":527.7999999523163,"connectStart":527.7999999523163,"domainLookupEnd":527.7999999523163,"domainLookupStart":527.7999999523163,"fetchStart":527.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":527.7999999523163,"responseEnd":1607.6000001430511,"responseStart":1607.6000001430511,"secureConnectionStart":527.7999999523163},{"duration":1095.3999998569489,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":528.1000001430511,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":528.1000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1623.5,"responseStart":0,"secureConnectionStart":0},{"duration":1080.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":528.2999999523163,"connectEnd":528.2999999523163,"connectStart":528.2999999523163,"domainLookupEnd":528.2999999523163,"domainLookupStart":528.2999999523163,"fetchStart":528.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":528.2999999523163,"responseEnd":1608.5,"responseStart":1608.4000000953674,"secureConnectionStart":528.2999999523163},{"duration":1095.2999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":528.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":528.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1623.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":1080.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":528.6000001430511,"connectEnd":528.6000001430511,"connectStart":528.6000001430511,"domainLookupEnd":528.6000001430511,"domainLookupStart":528.6000001430511,"fetchStart":528.6000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":528.6000001430511,"responseEnd":1609.2000000476837,"responseStart":1609.2000000476837,"secureConnectionStart":528.6000001430511},{"duration":1521.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":544,"connectEnd":544,"connectStart":544,"domainLookupEnd":544,"domainLookupStart":544,"fetchStart":544,"redirectEnd":0,"redirectStart":0,"requestStart":544,"responseEnd":2065.4000000953674,"responseStart":2065.4000000953674,"secureConnectionStart":544},{"duration":1798.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":544.1000001430511,"connectEnd":544.1000001430511,"connectStart":544.1000001430511,"domainLookupEnd":544.1000001430511,"domainLookupStart":544.1000001430511,"fetchStart":544.1000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":544.1000001430511,"responseEnd":2342.9000000953674,"responseStart":2342.9000000953674,"secureConnectionStart":544.1000001430511},{"duration":436.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1629.2000000476837,"connectEnd":1629.2000000476837,"connectStart":1629.2000000476837,"domainLookupEnd":1629.2000000476837,"domainLookupStart":1629.2000000476837,"fetchStart":1629.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1629.2000000476837,"responseEnd":2065.7999999523163,"responseStart":2065.7999999523163,"secureConnectionStart":1629.2000000476837},{"duration":421.09999990463257,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":2016.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":2016.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2437.7999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":352,"responseStart":521,"responseEnd":534,"domLoading":525,"domInteractive":2465,"domContentLoadedEventStart":2465,"domContentLoadedEventEnd":2540,"domComplete":2916,"loadEventStart":2916,"loadEventEnd":2917,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2438.9000000953674},{"name":"bigPipe.sidebar-id.end","time":2439.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":2439.7999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":2441.2000000476837},{"name":"activityTabFullyLoaded","time":2565.600000143051}],"measures":[],"correlationId":"890446f43ffdbd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":107,"dbReadsTimeInMs":17,"dbConnsTimeInMs":26,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
MDEV-33478 Tests massively fail with clang-18 -fsanitize=memory
