Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33490

Syntax errors in Spider error messages

Details

    Description

      I encountered this error in the tests

      This xid is not exist

      it turned to be a message defined in Spider, in storage/spider/spd_err.h. I looked at the list, and since these are user-visible errors, it is worth submitting the whole list for review and correction by a documentation expert.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17059 Replication stopped with error 12605 'This xid is already exist'

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34064 ERROR 12607 (HY000): This xid is not exist and Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed from change_master()

          • Major - Major loss of function.
          • Confirmed

          Activity

            Ascending order - Click to sort in descending order
            Roel Roel Van de Paar added a comment -

            Another example in MDEV-17059: 'This xid is already exist'

            Subject to further review as per the documentation expert suggestion, a more correct spelling would be 'This XID does not exist' and 'This XID already exists'.

            Roel Roel Van de Paar added a comment - Another example in MDEV-17059 : 'This xid is already exist' Subject to further review as per the documentation expert suggestion, a more correct spelling would be 'This XID does not exist' and 'This XID already exists'.
            ycp Yuchen Pei added a comment - - edited

            Hi holyfoot, ptal thanks

            3f5a56a78dc upstream/bb-10.5-mdev-33490 MDEV-33490 MENT-1504 Fix some english strings in spider.

            ycp Yuchen Pei added a comment - - edited Hi holyfoot , ptal thanks 3f5a56a78dc upstream/bb-10.5-mdev-33490 MDEV-33490 MENT-1504 Fix some english strings in spider.
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            thanks for the review - pushed 581712b989f47e4cc0206b0b470b8fcd80acbc83 to 10.5 yesterday

            ycp Yuchen Pei added a comment - thanks for the review - pushed 581712b989f47e4cc0206b0b470b8fcd80acbc83 to 10.5 yesterday

            People

              ycp Yuchen Pei
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.