Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32983

path separator near ib_buffer_pool incorrect

Details

    Description

      From https://github.com/ApacheFriends/xampp-build/issues/33 on windows:

      2023-12-10 13:20:06 0 [Note] InnoDB: Loading buffer pool(s) from C:\xampp\mysql\data/ib_buffer_pool
      		 
      2023-12-10 13:20:06 0 [Note] mysqld.exe: SSPI: using principal name 'localhost', mech 'Negotiate'
      		 
      2023-12-10 13:20:06 0 [Note] InnoDB: Cannot open 'C:\xampp\mysql\data/ib_buffer_pool' for reading: No such file or directory

      10.4/10.5 had OS_PATH_SEPARATOR, but 10.6 when straight to "/".

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-25312 Remove fil_space_t::name and related code

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black added a comment -

            Curious why it wasn't noticed in CI.

            https://github.com/MariaDB/server/pull/2915

            danblack Daniel Black added a comment - Curious why it wasn't noticed in CI. https://github.com/MariaDB/server/pull/2915
            marko Marko Mäkelä added a comment -

            Wasn’t this an intentional change that was done in MDEV-25312?

            marko Marko Mäkelä added a comment - Wasn’t this an intentional change that was done in MDEV-25312 ?
            celestinoxp Celestino Laranjeira added a comment - - edited

            I reported the problem on github (it should be on jira.mariadb.org) about the bars because the log shows: Cannot open 'C:\xampp\mysql\data/ib_buffer_pool', I was confused because the last bar is the opposite of the others. I also verified that there is no ib_buffer_pool file in the folder. MariaDB has ibdata, ib_logfile0, ibtmp1.
            I'm using Windows 11 and MariaDB 10.11 (snapshot from ci.maradb.org).
            I also have another question:
            in this line the slashes are forward slanted "/": InnoDB: Setting file 'C:/xampp/mysql/data/ibtmp1' size to 12.000MiB.
            and on this line are slanted back "\": c:\xampp\mysql\bin\mysqld.exe: ready for connections.

            This is normal? In windows, shouldn't the bars all be angled towards the back "\" ?

            celestinoxp Celestino Laranjeira added a comment - - edited I reported the problem on github (it should be on jira.mariadb.org) about the bars because the log shows: Cannot open 'C:\xampp\mysql\data/ib_buffer_pool', I was confused because the last bar is the opposite of the others. I also verified that there is no ib_buffer_pool file in the folder. MariaDB has ibdata, ib_logfile0, ibtmp1. I'm using Windows 11 and MariaDB 10.11 (snapshot from ci.maradb.org). I also have another question: in this line the slashes are forward slanted "/": InnoDB: Setting file 'C:/xampp/mysql/data/ibtmp1' size to 12.000MiB. and on this line are slanted back "\": c:\xampp\mysql\bin\mysqld.exe: ready for connections. This is normal? In windows, shouldn't the bars all be angled towards the back "\" ?
            marko Marko Mäkelä added a comment -

            As noted in the commit message that I linked, the forward slashes work just as fine as backslashes on Microsoft Windows, except for absolute path names that start with \\?\. Sure, the forward slashes may be confusing to users. I think that this needs to be decided by wlad, who approved the original simplification.

            marko Marko Mäkelä added a comment - As noted in the commit message that I linked, the forward slashes work just as fine as backslashes on Microsoft Windows, except for absolute path names that start with \\?\. Sure, the forward slashes may be confusing to users. I think that this needs to be decided by wlad , who approved the original simplification.
            wlad Vladislav Vaintroub added a comment - - edited

            Both forward slashes and backward slashes work on Windows . We do not use \\?\ names. I do not think it makes sense to "unify" the slashes, but within a single path it looks better if they point in the same direction, and would not mislead the users to think it would be a bug.

            So this could be classified as cosmetics bug, and prioritized accordingly.

            wlad Vladislav Vaintroub added a comment - - edited Both forward slashes and backward slashes work on Windows . We do not use \\?\ names. I do not think it makes sense to "unify" the slashes, but within a single path it looks better if they point in the same direction, and would not mislead the users to think it would be a bug. So this could be classified as cosmetics bug, and prioritized accordingly.
            celestinoxp Celestino Laranjeira added a comment -

            Has this problem already been resolved? Is the updated code already merged?

            celestinoxp Celestino Laranjeira added a comment - Has this problem already been resolved? Is the updated code already merged?
            danblack Daniel Black added a comment -

            I just got back from leave and need to take into account some feedback marko provided last year. Not too long now.

            danblack Daniel Black added a comment - I just got back from leave and need to take into account some feedback marko provided last year. Not too long now.

            People

              danblack Daniel Black
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.