[MDEV-32983] path separator near ib_buffer_pool incorrect Created: 2023-12-10  Updated: 2024-01-22  Resolved: 2024-01-22

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.6.16, 10.11.6
Fix Version/s: 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3

Type: Bug Priority: Trivial
Reporter: Daniel Black Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: not-10.4, not-10.5

Issue Links:
Relates
relates to MDEV-25312 Remove fil_space_t::name and related ... Closed

 Description   

From https://github.com/ApacheFriends/xampp-build/issues/33 on windows:

2023-12-10 13:20:06 0 [Note] InnoDB: Loading buffer pool(s) from C:\xampp\mysql\data/ib_buffer_pool
 
2023-12-10 13:20:06 0 [Note] mysqld.exe: SSPI: using principal name 'localhost', mech 'Negotiate'
 
2023-12-10 13:20:06 0 [Note] InnoDB: Cannot open 'C:\xampp\mysql\data/ib_buffer_pool' for reading: No such file or directory

10.4/10.5 had OS_PATH_SEPARATOR, but 10.6 when straight to "/".

 Comments   
Comment by Daniel Black [ 2023-12-10 ]

Curious why it wasn't noticed in CI.

https://github.com/MariaDB/server/pull/2915

Comment by Marko Mäkelä [ 2023-12-11 ]

Wasn’t this an intentional change that was done in MDEV-25312?

Comment by Celestino Laranjeira [ 2023-12-11 ]

I reported the problem on github (it should be on jira.mariadb.org) about the bars because the log shows: Cannot open 'C:\xampp\mysql\data/ib_buffer_pool', I was confused because the last bar is the opposite of the others. I also verified that there is no ib_buffer_pool file in the folder. MariaDB has ibdata, ib_logfile0, ibtmp1.
I'm using Windows 11 and MariaDB 10.11 (snapshot from ci.maradb.org).
I also have another question:
in this line the slashes are forward slanted "/": InnoDB: Setting file 'C:/xampp/mysql/data/ibtmp1' size to 12.000MiB.
and on this line are slanted back "\": c:\xampp\mysql\bin\mysqld.exe: ready for connections.

This is normal? In windows, shouldn't the bars all be angled towards the back "\" ?

Comment by Marko Mäkelä [ 2023-12-11 ]

As noted in the commit message that I linked, the forward slashes work just as fine as backslashes on Microsoft Windows, except for absolute path names that start with \\?\. Sure, the forward slashes may be confusing to users. I think that this needs to be decided by wlad, who approved the original simplification.

Comment by Vladislav Vaintroub [ 2023-12-11 ]

Both forward slashes and backward slashes work on Windows . We do not use \\?\ names. I do not think it makes sense to "unify" the slashes, but within a single path it looks better if they point in the same direction, and would not mislead the users to think it would be a bug.

So this could be classified as cosmetics bug, and prioritized accordingly.

Comment by Celestino Laranjeira [ 2024-01-06 ]

Has this problem already been resolved? Is the updated code already merged?

Comment by Daniel Black [ 2024-01-09 ]

I just got back from leave and need to take into account some feedback marko provided last year. Not too long now.

Generated at Thu Feb 08 10:35:30 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.