Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32189

use icu for timezones on windows

Details

    Description

      icu.lib is now apparently included by default in all supported versions on Windows.

      it can provide more portable results than Win32 API when dealing with time zones in Time_zone_system::get_timezone_information() and get_win_tzname().

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33096 mysys/my_timezone.cc does not compile on AIX

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-31684 Add timezone information to DATE_FORMAT

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            rucha174 Rucha Deodhar added a comment -

            Looks ok to push. Thanks !

            rucha174 Rucha Deodhar added a comment - Looks ok to push. Thanks !
            danblack Daniel Black added a comment -

            This needs a tester signoff first right - https://mariadb.com/kb/en/mariadb-quality-development-rules/

            danblack Daniel Black added a comment - This needs a tester signoff first right - https://mariadb.com/kb/en/mariadb-quality-development-rules/
            wlad Vladislav Vaintroub added a comment -

            "New features" need tester signoff. Lets see it as a fix, that also adds unit tests for the previous functionality (also outside of Windows)

            wlad Vladislav Vaintroub added a comment - "New features" need tester signoff. Lets see it as a fix, that also adds unit tests for the previous functionality (also outside of Windows)

            People

              wlad Vladislav Vaintroub
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.