Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32002

Remove my_casedn_str() in append_identifier() context

Details

    Description

      Under terms of MDEV-27490 we'll swith to Unicode-14.0.0. In this Unicode version a string can grow during a casedb conversion. We need to remove all my_casedn_str() calls done for identifiers.

      Under tems of this task, let's remove my_casedn_str() whose results are further passed to append_identifier().

      Let's add this helper function:

      bool append_identifier_opt_casedn(THD *thd, String *to,
      		 
                                        const LEX_CSTRING &ident, bool casedn)
      		 
      {
      		 
        if (!casedn)
      		 
          return append_identifier(thd, to, &ident);
      		 
        CharBuffer<MAX_ALIAS_NAME> buff;
      		 
        LEX_CSTRING ls= buff.copy_casedn(system_charset_info, ident).to_lex_cstring();
      		 
        return append_identifier(thd, to, &ls);
      		 
      }

      and reuse it in:

      • Item_ident::print()
      • Item_func_nextval::print()
      • Item_func_setval::print()

      This change is also expected to reduce the code size.

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. MDEV-27490 Allow full utf8mb4 for identifiers

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled

          Task - A task that needs to be done. MDEV-31531 Remove my_casedn_str() and my_caseup_str()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31606 Refactor check_db_name() to get a const argument

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2023-08-24 11:10:11.0 2023-08-24 11:10:11.387
            bar Alexander Barkov made changes -
            Fix Version/s 11.3.0 [ 29302 ]
            Fix Version/s 11.3 [ 28565 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ]
            Status Open [ 1 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            bar Alexander Barkov made changes -

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.