Type:
Task
Priority:
Major
Resolution:
Fixed
The main goal of this task is to change the data type of the global variable any_db from LEX_CSTRING to Lex_ident_db , to make upcoming changes easier:
- const LEX_CSTRING any_db= {STRING_WITH_LEN( "*any*" )};
+ const Lex_ident_db any_db(STRING_WITH_LEN( "*any*" ));
But most changes have to be done in Lex_ident_fs::check_body() , hence the task title.
Lex_ident_fs::check_body() depends from system_charset_info , which is initialized after any_db during the server startup.
So we need to change system_charset_info to direct use of my_charset_utf8mb3_general_ci .
Additionally, let's remove the unused code from Lex_ident_fs::check_body() .
We always compile in the way that this condition evaluates to true:
#if defined(USE_MB) && defined(USE_MB_IDENT)
...
#else
...
#endif
There is no sence to keep the old MySQL-4.0 code from the "#else" branch.
There are no comments yet on this issue.
{"report":{"fcp":802.9000000953674,"ttfb":193.29999995231628,"pageVisibility":"visible","entityId":124449,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"253182b3-7d91-4934-a27d-7770308fc45f","navigationType":0,"readyForUser":883.1000001430511,"redirectCount":0,"resourceLoadedEnd":870.7000000476837,"resourceLoadedStart":198.79999995231628,"resourceTiming":[{"duration":95.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":198.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":198.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":294.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":96.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":199,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":199,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":295.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":104.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":199.29999995231628,"connectEnd":199.29999995231628,"connectStart":199.29999995231628,"domainLookupEnd":199.29999995231628,"domainLookupStart":199.29999995231628,"fetchStart":199.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":199.29999995231628,"responseEnd":304.10000014305115,"responseStart":304.10000014305115,"secureConnectionStart":199.29999995231628},{"duration":210.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":199.40000009536743,"connectEnd":199.40000009536743,"connectStart":199.40000009536743,"domainLookupEnd":199.40000009536743,"domainLookupStart":199.40000009536743,"fetchStart":199.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":199.40000009536743,"responseEnd":409.5,"responseStart":409.5,"secureConnectionStart":199.40000009536743},{"duration":213.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":199.60000014305115,"connectEnd":199.60000014305115,"connectStart":199.60000014305115,"domainLookupEnd":199.60000014305115,"domainLookupStart":199.60000014305115,"fetchStart":199.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":199.60000014305115,"responseEnd":413.40000009536743,"responseStart":413.40000009536743,"secureConnectionStart":199.60000014305115},{"duration":214,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":199.79999995231628,"connectEnd":199.79999995231628,"connectStart":199.79999995231628,"domainLookupEnd":199.79999995231628,"domainLookupStart":199.79999995231628,"fetchStart":199.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":199.79999995231628,"responseEnd":413.7999999523163,"responseStart":413.7999999523163,"secureConnectionStart":199.79999995231628},{"duration":214.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":200,"connectEnd":200,"connectStart":200,"domainLookupEnd":200,"domainLookupStart":200,"fetchStart":200,"redirectEnd":0,"redirectStart":0,"requestStart":200,"responseEnd":414.2000000476837,"responseStart":414.2000000476837,"secureConnectionStart":200},{"duration":249.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":200.10000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":449.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":214.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":200.29999995231628,"connectEnd":200.29999995231628,"connectStart":200.29999995231628,"domainLookupEnd":200.29999995231628,"domainLookupStart":200.29999995231628,"fetchStart":200.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":200.29999995231628,"responseEnd":414.60000014305115,"responseStart":414.60000014305115,"secureConnectionStart":200.29999995231628},{"duration":248.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":200.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":449.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":214.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":200.60000014305115,"connectEnd":200.60000014305115,"connectStart":200.60000014305115,"domainLookupEnd":200.60000014305115,"domainLookupStart":200.60000014305115,"fetchStart":200.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":200.60000014305115,"responseEnd":415.2999999523163,"responseStart":415.2999999523163,"secureConnectionStart":200.60000014305115},{"duration":274.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":201.60000014305115,"connectEnd":201.60000014305115,"connectStart":201.60000014305115,"domainLookupEnd":201.60000014305115,"domainLookupStart":201.60000014305115,"fetchStart":201.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":201.60000014305115,"responseEnd":476.10000014305115,"responseStart":476.10000014305115,"secureConnectionStart":201.60000014305115},{"duration":302.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":201.60000014305115,"connectEnd":201.60000014305115,"connectStart":201.60000014305115,"domainLookupEnd":201.60000014305115,"domainLookupStart":201.60000014305115,"fetchStart":201.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":201.60000014305115,"responseEnd":503.90000009536743,"responseStart":503.90000009536743,"secureConnectionStart":201.60000014305115},{"duration":28.200000047683716,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":461.2000000476837,"connectEnd":461.2000000476837,"connectStart":461.2000000476837,"domainLookupEnd":461.2000000476837,"domainLookupStart":461.2000000476837,"fetchStart":461.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":461.2000000476837,"responseEnd":489.40000009536743,"responseStart":489.40000009536743,"secureConnectionStart":461.2000000476837},{"duration":16.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":492.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":492.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":509,"responseStart":0,"secureConnectionStart":0},{"duration":376.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":493.7999999523163,"connectEnd":493.7999999523163,"connectStart":493.7999999523163,"domainLookupEnd":493.7999999523163,"domainLookupStart":493.7999999523163,"fetchStart":493.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":493.7999999523163,"responseEnd":870.7000000476837,"responseStart":870.7000000476837,"secureConnectionStart":493.7999999523163},{"duration":192.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":584.7999999523163,"connectEnd":584.7999999523163,"connectStart":584.7999999523163,"domainLookupEnd":584.7999999523163,"domainLookupStart":584.7999999523163,"fetchStart":584.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":584.7999999523163,"responseEnd":777.2999999523163,"responseStart":777.2999999523163,"secureConnectionStart":584.7999999523163}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":43,"responseStart":194,"responseEnd":195,"domLoading":197,"domInteractive":936,"domContentLoadedEventStart":936,"domContentLoadedEventEnd":977,"domComplete":1071,"loadEventStart":1071,"loadEventEnd":1071,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":919.1000001430511},{"name":"bigPipe.sidebar-id.end","time":920.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":920.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":920.7999999523163},{"name":"activityTabFullyLoaded","time":984.7999999523163}],"measures":[],"correlationId":"da5a303d514883","effectiveType":"4g","downlink":9.1,"rtt":0,"serverDuration":92,"dbReadsTimeInMs":12,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}