Type:
Task
Priority:
Major
Resolution:
Fixed
The code in check_table_name() and check_db_name() looks confusing.
Let's do minor cleanups:
Rename the parameter check_for_path_char to a more self-descriptive disallow_path_chars
Rename the variable name_length in check_table_name() to a more self-descriptive char_length.
Fix the while loop in check_table_name() into a for loop and replace multiple char_length+ (the former name_length + ) statements to a signle increment statement in the for loop header.
blocks
MDEV-31606
Refactor check_db_name() to get a const argument
Closed
Alexander Barkov
made changes -
2023-08-18 12:08
issue.field.resolutiondate
2023-08-18 12:08:47.0
2023-08-18 12:08:47.206
Alexander Barkov
made changes -
2023-08-18 12:08
Fix Version/s
11.3.0
[ 29302
]
Fix Version/s
11.3
[ 28565
]
Resolution
Fixed
[ 1
]
Status
Open
[ 1
]
Closed
[ 6
]
Alexander Barkov
made changes -
2023-09-17 16:28
Assignee
Alexander Barkov
[ bar
]
{"report":{"fcp":2675.0999994277954,"ttfb":850.2999992370605,"pageVisibility":"visible","entityId":124338,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"a3d48fa5-9a1a-4182-8435-7524c84e5341","navigationType":0,"readyForUser":2755.199999809265,"redirectCount":0,"resourceLoadedEnd":2112.699999809265,"resourceLoadedStart":857.5,"resourceTiming":[{"duration":282.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":857.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":857.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1140.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":283.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":857.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":857.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1141.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":1017.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":858.0999994277954,"connectEnd":858.0999994277954,"connectStart":858.0999994277954,"domainLookupEnd":858.0999994277954,"domainLookupStart":858.0999994277954,"fetchStart":858.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":1152.5,"responseEnd":1875.5999994277954,"responseStart":1177.3999996185303,"secureConnectionStart":858.0999994277954},{"duration":1216.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":858.1999998092651,"connectEnd":858.1999998092651,"connectStart":858.1999998092651,"domainLookupEnd":858.1999998092651,"domainLookupStart":858.1999998092651,"fetchStart":858.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1152.8999996185303,"responseEnd":2074.7999992370605,"responseStart":1184.6999998092651,"secureConnectionStart":858.1999998092651},{"duration":344,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":858.5,"connectEnd":858.5,"connectStart":858.5,"domainLookupEnd":858.5,"domainLookupStart":858.5,"fetchStart":858.5,"redirectEnd":0,"redirectStart":0,"requestStart":1158.3999996185303,"responseEnd":1202.5,"responseStart":1199.5,"secureConnectionStart":858.5},{"duration":366.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":858.5999994277954,"connectEnd":858.5999994277954,"connectStart":858.5999994277954,"domainLookupEnd":858.5999994277954,"domainLookupStart":858.5999994277954,"fetchStart":858.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":1171,"responseEnd":1224.6999998092651,"responseStart":1215.5999994277954,"secureConnectionStart":858.5999994277954},{"duration":372.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":858.8999996185303,"connectEnd":858.8999996185303,"connectStart":858.8999996185303,"domainLookupEnd":858.8999996185303,"domainLookupStart":858.8999996185303,"fetchStart":858.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":1171.1999998092651,"responseEnd":1231.1999998092651,"responseStart":1217.5999994277954,"secureConnectionStart":858.8999996185303},{"duration":296.6000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":859.0999994277954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":859.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1155.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":372.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":859.2999992370605,"connectEnd":859.2999992370605,"connectStart":859.2999992370605,"domainLookupEnd":859.2999992370605,"domainLookupStart":859.2999992370605,"fetchStart":859.2999992370605,"redirectEnd":0,"redirectStart":0,"requestStart":1172.5999994277954,"responseEnd":1231.3999996185303,"responseStart":1218.6999998092651,"secureConnectionStart":859.2999992370605},{"duration":298,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":859.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":859.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1157.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":395.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":859.5999994277954,"connectEnd":859.5999994277954,"connectStart":859.5999994277954,"domainLookupEnd":859.5999994277954,"domainLookupStart":859.5999994277954,"fetchStart":859.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":1174.5999994277954,"responseEnd":1254.7999992370605,"responseStart":1220.2999992370605,"secureConnectionStart":859.5999994277954},{"duration":1250.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":860.3999996185303,"connectEnd":860.3999996185303,"connectStart":860.3999996185303,"domainLookupEnd":860.3999996185303,"domainLookupStart":860.3999996185303,"fetchStart":860.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":1383.8999996185303,"responseEnd":2110.7999992370605,"responseStart":2087.0999994277954,"secureConnectionStart":860.3999996185303},{"duration":1252.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":860.5,"connectEnd":860.5,"connectStart":860.5,"domainLookupEnd":860.5,"domainLookupStart":860.5,"fetchStart":860.5,"redirectEnd":0,"redirectStart":0,"requestStart":1781,"responseEnd":2112.699999809265,"responseStart":2096.5,"secureConnectionStart":860.5},{"duration":326.5999994277954,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":2012.5,"connectEnd":2012.5,"connectStart":2012.5,"domainLookupEnd":2012.5,"domainLookupStart":2012.5,"fetchStart":2012.5,"redirectEnd":0,"redirectStart":0,"requestStart":2306.5,"responseEnd":2339.0999994277954,"responseStart":2338.199999809265,"secureConnectionStart":2012.5}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":673,"responseStart":850,"responseEnd":855,"domLoading":855,"domInteractive":2883,"domContentLoadedEventStart":2883,"domContentLoadedEventEnd":2954,"domComplete":3567,"loadEventStart":3567,"loadEventEnd":3568,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2806.7999992370605},{"name":"bigPipe.sidebar-id.end","time":2807.699999809265},{"name":"bigPipe.activity-panel-pipe-id.start","time":2807.7999992370605},{"name":"bigPipe.activity-panel-pipe-id.end","time":2809.699999809265},{"name":"activityTabFullyLoaded","time":2971.699999809265}],"measures":[],"correlationId":"ea93bda8358513","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":99,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}