Type:
Task
Priority:
Major
Resolution:
Fixed
The following ha_spider methods inside ha_spider.cc call spider_check_and_init_casual_read()
ft_read_internal multi_range_read_next_first
index_first_map_internal multi_range_read_next_next
index_last_internal range_read_first_internal
index_read_last_map_internal rnd_next_internal
index_read_map_internal
Near the callsite is about 80 lines of repeated code. Part of the repeated region is also a common pattern found in other spider files and functions. They need to be factored out.
See the attached gif for an IDE demo, as well as attached .cc files with these functions extracted out (at 11.0 941f91edbc3d3a0a184b9bfc58d5e4042c4b65f1).
{"report":{"fcp":1065.4000000953674,"ttfb":311.2000002861023,"pageVisibility":"visible","entityId":123729,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":0.5,"journeyId":"1310616c-f550-433b-b100-01187f6a8470","navigationType":0,"readyForUser":1179.9000000953674,"redirectCount":0,"resourceLoadedEnd":747.5,"resourceLoadedStart":319.40000009536743,"resourceTiming":[{"duration":108.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":319.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":319.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":427.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":108.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":319.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":319.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":428,"responseStart":0,"secureConnectionStart":0},{"duration":285.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":320,"connectEnd":320,"connectStart":320,"domainLookupEnd":320,"domainLookupStart":320,"fetchStart":320,"redirectEnd":0,"redirectStart":0,"requestStart":431,"responseEnd":605.5,"responseStart":448.59999990463257,"secureConnectionStart":320},{"duration":427.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":320.40000009536743,"connectEnd":320.40000009536743,"connectStart":320.40000009536743,"domainLookupEnd":320.40000009536743,"domainLookupStart":320.40000009536743,"fetchStart":320.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":431.40000009536743,"responseEnd":747.5,"responseStart":446.30000019073486,"secureConnectionStart":320.40000009536743},{"duration":134.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":320.59999990463257,"connectEnd":320.59999990463257,"connectStart":320.59999990463257,"domainLookupEnd":320.59999990463257,"domainLookupStart":320.59999990463257,"fetchStart":320.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":431.59999990463257,"responseEnd":455.09999990463257,"responseStart":454.2000002861023,"secureConnectionStart":320.59999990463257},{"duration":136.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":320.80000019073486,"connectEnd":320.80000019073486,"connectStart":320.80000019073486,"domainLookupEnd":320.80000019073486,"domainLookupStart":320.80000019073486,"fetchStart":320.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":432.80000019073486,"responseEnd":456.90000009536743,"responseStart":455.5,"secureConnectionStart":320.80000019073486},{"duration":137.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":320.90000009536743,"connectEnd":320.90000009536743,"connectStart":320.90000009536743,"domainLookupEnd":320.90000009536743,"domainLookupStart":320.90000009536743,"fetchStart":320.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":433.59999990463257,"responseEnd":458.2000002861023,"responseStart":457.30000019073486,"secureConnectionStart":320.90000009536743},{"duration":112,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":321.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":321.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":433.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":142.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":321.30000019073486,"connectEnd":321.30000019073486,"connectStart":321.30000019073486,"domainLookupEnd":321.30000019073486,"domainLookupStart":321.30000019073486,"fetchStart":321.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":436.5,"responseEnd":463.59999990463257,"responseStart":462,"secureConnectionStart":321.30000019073486},{"duration":113.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":321.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":321.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":434.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":158.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":321.59999990463257,"connectEnd":321.59999990463257,"connectStart":321.59999990463257,"domainLookupEnd":321.59999990463257,"domainLookupStart":321.59999990463257,"fetchStart":321.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":437.2000002861023,"responseEnd":480.5,"responseStart":462.59999990463257,"secureConnectionStart":321.59999990463257},{"duration":368.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":324.40000009536743,"connectEnd":324.40000009536743,"connectStart":324.40000009536743,"domainLookupEnd":324.40000009536743,"domainLookupStart":324.40000009536743,"fetchStart":324.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":509.5,"responseEnd":692.9000000953674,"responseStart":679.9000000953674,"secureConnectionStart":324.40000009536743},{"duration":370,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":324.59999990463257,"connectEnd":324.59999990463257,"connectStart":324.59999990463257,"domainLookupEnd":324.59999990463257,"domainLookupStart":324.59999990463257,"fetchStart":324.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":560.3000001907349,"responseEnd":694.5999999046326,"responseStart":683.2000002861023,"secureConnectionStart":324.59999990463257},{"duration":207.39999961853027,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":734.7000002861023,"connectEnd":734.7000002861023,"connectStart":734.7000002861023,"domainLookupEnd":734.7000002861023,"domainLookupStart":734.7000002861023,"fetchStart":734.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":905.4000000953674,"responseEnd":942.0999999046326,"responseStart":941.5,"secureConnectionStart":734.7000002861023},{"duration":312.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":996.3000001907349,"connectEnd":996.3000001907349,"connectStart":996.3000001907349,"domainLookupEnd":996.3000001907349,"domainLookupStart":996.3000001907349,"fetchStart":996.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":1271.5,"responseEnd":1308.9000000953674,"responseStart":1308.3000001907349,"secureConnectionStart":996.3000001907349},{"duration":255.7000002861023,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1056.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1056.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1312.3000001907349,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":80,"domainLookupEnd":90,"connectStart":90,"connectEnd":113,"secureConnectionStart":101,"requestStart":114,"responseStart":312,"responseEnd":324,"domLoading":315,"domInteractive":1315,"domContentLoadedEventStart":1315,"domContentLoadedEventEnd":1377,"domComplete":3635,"loadEventStart":3635,"loadEventEnd":3637,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1290.3000001907349},{"name":"bigPipe.sidebar-id.end","time":1291.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1291.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1294.8000001907349},{"name":"activityTabFullyLoaded","time":1389}],"measures":[],"correlationId":"e503e1154294bd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":129,"dbReadsTimeInMs":12,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}