Type:
Task
Priority:
Major
Resolution:
Fixed
The following ha_spider methods inside ha_spider.cc call spider_check_and_init_casual_read()
ft_read_internal multi_range_read_next_first
index_first_map_internal multi_range_read_next_next
index_last_internal range_read_first_internal
index_read_last_map_internal rnd_next_internal
index_read_map_internal
Near the callsite is about 80 lines of repeated code. Part of the repeated region is also a common pattern found in other spider files and functions. They need to be factored out.
See the attached gif for an IDE demo, as well as attached .cc files with these functions extracted out (at 11.0 941f91edbc3d3a0a184b9bfc58d5e4042c4b65f1).
{"report":{"fcp":1564.0999999046326,"ttfb":325.19999980926514,"pageVisibility":"visible","entityId":123729,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"ca2fe81d-fdf9-4563-9aff-a560e83ea2a3","navigationType":0,"readyForUser":1643.3000001907349,"redirectCount":0,"resourceLoadedEnd":2192.5999999046326,"resourceLoadedStart":338,"resourceTiming":[{"duration":430,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":338,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":338,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":768,"responseStart":0,"secureConnectionStart":0},{"duration":430,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":338.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":338.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":768.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":461.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":338.5,"connectEnd":338.5,"connectStart":338.5,"domainLookupEnd":338.5,"domainLookupStart":338.5,"fetchStart":338.5,"redirectEnd":0,"redirectStart":0,"requestStart":338.5,"responseEnd":799.9000000953674,"responseStart":799.9000000953674,"secureConnectionStart":338.5},{"duration":560.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":338.59999990463257,"connectEnd":338.59999990463257,"connectStart":338.59999990463257,"domainLookupEnd":338.59999990463257,"domainLookupStart":338.59999990463257,"fetchStart":338.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":338.59999990463257,"responseEnd":899.1999998092651,"responseStart":899.1999998092651,"secureConnectionStart":338.59999990463257},{"duration":564.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":338.80000019073486,"connectEnd":338.80000019073486,"connectStart":338.80000019073486,"domainLookupEnd":338.80000019073486,"domainLookupStart":338.80000019073486,"fetchStart":338.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":338.80000019073486,"responseEnd":903.5999999046326,"responseStart":903.5999999046326,"secureConnectionStart":338.80000019073486},{"duration":565.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":339.09999990463257,"connectEnd":339.09999990463257,"connectStart":339.09999990463257,"domainLookupEnd":339.09999990463257,"domainLookupStart":339.09999990463257,"fetchStart":339.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":339.09999990463257,"responseEnd":904.1999998092651,"responseStart":904.1999998092651,"secureConnectionStart":339.09999990463257},{"duration":565.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":339.30000019073486,"connectEnd":339.30000019073486,"connectStart":339.30000019073486,"domainLookupEnd":339.30000019073486,"domainLookupStart":339.30000019073486,"fetchStart":339.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":339.30000019073486,"responseEnd":904.8000001907349,"responseStart":904.8000001907349,"secureConnectionStart":339.30000019073486},{"duration":658.1999998092651,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":339.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":339.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":997.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":566.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":339.59999990463257,"connectEnd":339.59999990463257,"connectStart":339.59999990463257,"domainLookupEnd":339.59999990463257,"domainLookupStart":339.59999990463257,"fetchStart":339.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":339.59999990463257,"responseEnd":906.1999998092651,"responseStart":906.1999998092651,"secureConnectionStart":339.59999990463257},{"duration":668,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":339.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":339.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1007.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":567.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":339.90000009536743,"connectEnd":339.90000009536743,"connectStart":339.90000009536743,"domainLookupEnd":339.90000009536743,"domainLookupStart":339.90000009536743,"fetchStart":339.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":339.90000009536743,"responseEnd":907.0999999046326,"responseStart":907.0999999046326,"secureConnectionStart":339.90000009536743},{"duration":1164.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":340.80000019073486,"connectEnd":340.80000019073486,"connectStart":340.80000019073486,"domainLookupEnd":340.80000019073486,"domainLookupStart":340.80000019073486,"fetchStart":340.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":340.80000019073486,"responseEnd":1505.5999999046326,"responseStart":1505.5999999046326,"secureConnectionStart":340.80000019073486},{"duration":1851.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":340.90000009536743,"connectEnd":340.90000009536743,"connectStart":340.90000009536743,"domainLookupEnd":340.90000009536743,"domainLookupStart":340.90000009536743,"fetchStart":340.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":340.90000009536743,"responseEnd":2192.5999999046326,"responseStart":2192.5999999046326,"secureConnectionStart":340.90000009536743},{"duration":471.30000019073486,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1040.0999999046326,"connectEnd":1040.0999999046326,"connectStart":1040.0999999046326,"domainLookupEnd":1040.0999999046326,"domainLookupStart":1040.0999999046326,"fetchStart":1040.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1040.0999999046326,"responseEnd":1511.4000000953674,"responseStart":1511.4000000953674,"secureConnectionStart":1040.0999999046326},{"duration":729.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1559.5,"connectEnd":1559.5,"connectStart":1559.5,"domainLookupEnd":1559.5,"domainLookupStart":1559.5,"fetchStart":1559.5,"redirectEnd":0,"redirectStart":0,"requestStart":1559.5,"responseEnd":2288.699999809265,"responseStart":2288.699999809265,"secureConnectionStart":1559.5},{"duration":731.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1560.6999998092651,"connectEnd":1560.6999998092651,"connectStart":1560.6999998092651,"domainLookupEnd":1560.6999998092651,"domainLookupStart":1560.6999998092651,"fetchStart":1560.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1560.6999998092651,"responseEnd":2292.4000000953674,"responseStart":2292.4000000953674,"secureConnectionStart":1560.6999998092651}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":130,"responseStart":326,"responseEnd":330,"domLoading":331,"domInteractive":2228,"domContentLoadedEventStart":2228,"domContentLoadedEventEnd":2281,"domComplete":3337,"loadEventStart":3337,"loadEventEnd":3338,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2203.300000190735},{"name":"bigPipe.sidebar-id.end","time":2204.199999809265},{"name":"bigPipe.activity-panel-pipe-id.start","time":2204.4000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":2205.9000000953674},{"name":"activityTabFullyLoaded","time":2299.5}],"measures":[],"correlationId":"bc7ceb9914488f","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":139,"dbReadsTimeInMs":45,"dbConnsTimeInMs":57,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}