Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.6.9, 10.9.2, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL), 10.11, 11.0(EOL)
-
None
Description
InnoDB should set the XDES_FREE_BIT of the page before checking whether the
current extent is free.
if (!xdes_get_n_used(descr)) {
|
/* The extent has become free: move it to another list */
|
err = flst_remove(header, FSP_HEADER_OFFSET + FSP_FREE_FRAG,
|
xdes, xoffset, mtr);
|
if (UNIV_UNLIKELY(err != DB_SUCCESS)) {
|
return err;
|
}
|
err = fsp_free_extent(space, offset, mtr);
|
if (UNIV_UNLIKELY(err != DB_SUCCESS)) {
|
return err;
|
}
|
}
|
|
|
mtr->free(*space, static_cast<uint32_t>(offset));
|
xdes_set_free<true>(*xdes, descr, offset % FSP_EXTENT_SIZE, mtr);
|
This issue was caused in 10.6 by the following patch:
commit 0b47c126e31cddda1e94588799599e138400bcf8
|
Author: Marko Mäkelä <marko.makela@mariadb.com>
|
Date: Mon Jun 6 14:03:22 2022 +0300
|
|
|
MDEV-13542: Crashing on corrupted page is unhelpful
|
Attachments
Issue Links
- is caused by
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Thirunarayanan Balathandayuthapani [ thiru ] | Marko Mäkelä [ marko ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Link |
This issue is caused by |
| Fix Version/s | 10.8 [ 26121 ] | |
| Affects Version/s | 10.9.2 [ 27115 ] | |
| Affects Version/s | 10.6.9 [ 27507 ] | |
| Affects Version/s | 10.7 [ 24805 ] |
OK to push. Thank you for catching this.
I understand that writing a test case for this is tricky. We will cover this in MDEV-14795, which is where you found this regression.
| Assignee | Marko Mäkelä [ marko ] | Thirunarayanan Balathandayuthapani [ thiru ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Fix Version/s | 11.1.1 [ 28704 ] | |
| Fix Version/s | 10.6.14 [ 28914 ] | |
| Fix Version/s | 10.9.7 [ 28916 ] | |
| Fix Version/s | 10.10.5 [ 28917 ] | |
| Fix Version/s | 10.11.4 [ 28918 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.9 [ 26905 ] | |
| Fix Version/s | 10.10 [ 27530 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.0 [ 28320 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Fix Version/s | 10.6.15 [ 29013 ] | |
| Fix Version/s | 10.9.8 [ 29015 ] | |
| Fix Version/s | 10.10.6 [ 29017 ] | |
| Fix Version/s | 10.11.5 [ 29019 ] | |
| Fix Version/s | 11.1.2 [ 28921 ] | |
| Fix Version/s | 11.1.1 [ 28704 ] | |
| Fix Version/s | 10.6.14 [ 28914 ] | |
| Fix Version/s | 10.9.7 [ 28916 ] | |
| Fix Version/s | 10.10.5 [ 28917 ] | |
| Fix Version/s | 10.11.4 [ 28918 ] |
Even though the extent is completely free, InnoDB fails to add the extent into FSP_FREE list. Extent doesn't get leaked in the tablespace.
Subsequent user actions could make use of the freed extent in FSP_FREE_FRAG List. User won't get affected by this issue.
Patch is in bb-10.6-
MDEV-31333