Details
-
Bug
-
Status: Open (View Workflow)
-
Major
-
Resolution: Unresolved
-
10.4.29
Description
From serg
The server already has checks like
if (opt_skip_name_resolve && |
hostname_requires_resolving(host.host.hostname))
|
{
|
sql_print_warning("'host' entry '%s|%s' " |
"ignored in --skip-name-resolve mode.", |
safe_str(host.host.hostname),
|
safe_str(host.db));
|
continue; |
}
|
But ip_to_hostname() is called like
if (!opt_skip_name_resolve) |
{
|
int rc; |
|
|
rc = ip_to_hostname(addr,
|
thd->main_security_ctx.ip,
|
&thd->main_security_ctx.host,
|
host_errors);
|
Why not to make it to be, like
if (!opt_skip_name_resove && there_are_hostnames_requiring_resolving) |
{
|
...
|
seems to be an easy thing to do. Then you can enable name resolution by default but it still won't do anything unless there's at least user entry that actually needs it. (edited)
caveat, need to check if enabling name resolution has any visible effects. Like, whether the hostname is shown in logs or in USER() whatever. if it does, you cannot just automatically skip it as above, but then we can add name-resolution=auto mode and make that the default.