MDEV-28861 deprecates the engine-defined options corresponding to major table options. So, we now can remove the table options, specified by COMMENT and CONNECTION, which have engine-defined option correspondence. Also, remove non-major, rarely used table options.
Attachments
Issue Links
is blocked by
MDEV-28861Spider: Deprecate table options by COMMENT
Closed
relates to
MDEV-27106Spider: specify connection to data node by engine-defined attributes
COMMENT is accepted, but SHOW CREATE TABLE shows options from MDEV-28861
COMMENT causes a deprecation warning
COMMENT is no longer parsed (after a some grace period after 2)
I'm afraid there's no proper way of implementing 1, so either we skip it or it'll be some kind of a hack (luckily, it's needed only temporarily, until 3)
Sergei Golubchik
added a comment - - edited I suggest this to be done in steps:
COMMENT is accepted, but SHOW CREATE TABLE shows options from MDEV-28861
COMMENT causes a deprecation warning
COMMENT is no longer parsed (after a some grace period after 2)
I'm afraid there's no proper way of implementing 1, so either we skip it or it'll be some kind of a hack (luckily, it's needed only temporarily, until 3)
Last I checked, the deprecation rule said: a feature should not be deleted until it's deprecated in all maintained versions.
Since table options by COMMENT was deprecated for 11.4 (MDEV-28861), we have to wait for all versions < 11.4 to EOL, which means this ticket needs to wait till 2028 (10.11 EOL). So I guess we'll just keep bumping the fixversion till then...
Yuchen Pei
added a comment - Last I checked, the deprecation rule said: a feature should not be deleted until it's deprecated in all maintained versions.
Since table options by COMMENT was deprecated for 11.4 ( MDEV-28861 ), we have to wait for all versions < 11.4 to EOL, which means this ticket needs to wait till 2028 (10.11 EOL). So I guess we'll just keep bumping the fixversion till then...
People
Yuchen Pei
Ralf Gebhardt
Votes:
1Vote for this issue
Watchers:
5Start watching this issue
Dates
Created:
Updated:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":1170.5999994277954,"ttfb":507.5999994277954,"pageVisibility":"visible","entityId":121441,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"87baf5f3-759a-4686-bf77-428af6d74b71","navigationType":0,"readyForUser":1230.3999996185303,"redirectCount":0,"resourceLoadedEnd":834.3999996185303,"resourceLoadedStart":514.6999998092651,"resourceTiming":[{"duration":7.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":514.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":514.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":522.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":7.600000381469727,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":514.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":514.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":522.5,"responseStart":0,"secureConnectionStart":0},{"duration":186.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":515.0999994277954,"connectEnd":515.0999994277954,"connectStart":515.0999994277954,"domainLookupEnd":515.0999994277954,"domainLookupStart":515.0999994277954,"fetchStart":515.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":523.3999996185303,"responseEnd":701.5999994277954,"responseStart":537.3999996185303,"secureConnectionStart":515.0999994277954},{"duration":297.79999923706055,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":515.3000001907349,"connectEnd":522.3999996185303,"connectStart":522.3999996185303,"domainLookupEnd":522.3999996185303,"domainLookupStart":522.3999996185303,"fetchStart":515.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":522.8999996185303,"responseEnd":813.0999994277954,"responseStart":540.5,"secureConnectionStart":522.3999996185303},{"duration":21.600000381469727,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":515.3999996185303,"connectEnd":515.3999996185303,"connectStart":515.3999996185303,"domainLookupEnd":515.3999996185303,"domainLookupStart":515.3999996185303,"fetchStart":515.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":523.6999998092651,"responseEnd":537,"responseStart":533.5999994277954,"secureConnectionStart":515.3999996185303},{"duration":41.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":515.6999998092651,"connectEnd":515.6999998092651,"connectStart":515.6999998092651,"domainLookupEnd":515.6999998092651,"domainLookupStart":515.6999998092651,"fetchStart":515.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":530.1999998092651,"responseEnd":557,"responseStart":551.3999996185303,"secureConnectionStart":515.6999998092651},{"duration":43.59999942779541,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":515.8000001907349,"connectEnd":515.8000001907349,"connectStart":515.8000001907349,"domainLookupEnd":515.8000001907349,"domainLookupStart":515.8000001907349,"fetchStart":515.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":530.8999996185303,"responseEnd":559.3999996185303,"responseStart":553.5999994277954,"secureConnectionStart":515.8000001907349},{"duration":10.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":515.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":515.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":526.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":43.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":516.0999994277954,"connectEnd":516.0999994277954,"connectStart":516.0999994277954,"domainLookupEnd":516.0999994277954,"domainLookupStart":516.0999994277954,"fetchStart":516.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":531.0999994277954,"responseEnd":559.6999998092651,"responseStart":554.6999998092651,"secureConnectionStart":516.0999994277954},{"duration":11.399999618530273,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":516.3000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":516.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":527.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":43.90000057220459,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":516.3999996185303,"connectEnd":516.3999996185303,"connectStart":516.3999996185303,"domainLookupEnd":516.3999996185303,"domainLookupStart":516.3999996185303,"fetchStart":516.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":531.3999996185303,"responseEnd":560.3000001907349,"responseStart":555.5,"secureConnectionStart":516.3999996185303},{"duration":307.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":519.5999994277954,"connectEnd":519.5999994277954,"connectStart":519.5999994277954,"domainLookupEnd":519.5999994277954,"domainLookupStart":519.5999994277954,"fetchStart":519.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":561.3999996185303,"responseEnd":827.3000001907349,"responseStart":825.3999996185303,"secureConnectionStart":519.5999994277954},{"duration":314.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":520.0999994277954,"connectEnd":520.0999994277954,"connectStart":520.0999994277954,"domainLookupEnd":520.0999994277954,"domainLookupStart":520.0999994277954,"fetchStart":520.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":568.8999996185303,"responseEnd":834.3999996185303,"responseStart":828.6999998092651,"secureConnectionStart":520.0999994277954},{"duration":165.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":834.8999996185303,"connectEnd":834.8999996185303,"connectStart":834.8999996185303,"domainLookupEnd":834.8999996185303,"domainLookupStart":834.8999996185303,"fetchStart":834.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":943.8000001907349,"responseEnd":1000.5999994277954,"responseStart":999.5999994277954,"secureConnectionStart":834.8999996185303}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":82,"responseStart":508,"responseEnd":520,"domLoading":511,"domInteractive":1282,"domContentLoadedEventStart":1282,"domContentLoadedEventEnd":1322,"domComplete":2405,"loadEventStart":2405,"loadEventEnd":2406,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1263.1999998092651},{"name":"bigPipe.sidebar-id.end","time":1264},{"name":"bigPipe.activity-panel-pipe-id.start","time":1264.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1265.3999996185303},{"name":"activityTabFullyLoaded","time":1337.8999996185303}],"measures":[],"correlationId":"6564c230397f25","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":97,"dbReadsTimeInMs":15,"dbConnsTimeInMs":23,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Task
Critical
I suggest this to be done in steps:
MDEV-28861I'm afraid there's no proper way of implementing 1, so either we skip it or it'll be some kind of a hack (luckily, it's needed only temporarily, until 3)