[MDEV-31092] mysqldump --force doesn't ignore error as it should - Jira

Susmeet Khaire created issue - 2023-04-20 05:08

Susmeet Khaire made changes - 2023-04-20 05:11

Field	Original Value	New Value
Description	Customer has few legacy functions. One the function has some syntax error. But more importantly customer is unable to take a dump of the function even with --force. Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object. This doesnt happen for this particular function. But the behaviour can be observed for "Views with missing tables" errors.	Customer has few legacy functions. One the function has some syntax error. But more importantly customer is unable to take a dump of the function even with --force. {code:java} [mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases tdsdbsgowner > ddl_tdsdbsgowner.sql Enter password: mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Failed to load routine tdsdbsgowner.FF1 (internal code -6). For more details, run SHOW WARNINGS (1457) {code} Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object. This doesnt happen for this particular function. But the behaviour can be observed for "Views with missing tables" errors.

Susmeet Khaire made changes - 2023-04-20 05:14

Description

Customer has few legacy functions.

One the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases tdsdbsgowner > ddl_tdsdbsgowner.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Failed to load routine tdsdbsgowner.FF1 (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Customer has few legacy functions.

One the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases {database}> dump.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Failed to load routine tdsdbsgowner.FF1 (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Susmeet Khaire made changes - 2023-04-20 05:15

Description

Customer has few legacy functions.

One the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases {database}> dump.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Failed to load routine tdsdbsgowner.FF1 (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Customer has few legacy functions.

One the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases xxxx> dump.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `ABC`': Failed to load routine xxxx.ABC (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Susmeet Khaire made changes - 2023-04-20 07:33

Summary

mysqldump --force doesn't ignore error as it should

PENDING mysqldump --force doesn't ignore error as it should

Susmeet Khaire made changes - 2023-04-21 00:13

Summary

PENDING mysqldump --force doesn't ignore error as it should

mysqldump --force doesn't ignore error as it should

Susmeet Khaire made changes - 2023-04-21 00:18

Description

Customer has few legacy functions.

One the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases xxxx> dump.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `ABC`': Failed to load routine xxxx.ABC (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Customer has few legacy functions.

One of the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases xxxx> dump.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `ABC`': Failed to load routine xxxx.ABC (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Susmeet Khaire made changes - 2023-04-21 00:27

Description

Customer has few legacy functions.

One of the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
[mysql@x01gtdsdb2a mysqldump]$ mysqldump -uinstadm -p --no-data --routines --events --triggers --max-allowed-packet=100M --single-transaction --force --databases xxxx> dump.sql
Enter password:
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `ABC`': Failed to load routine xxxx.ABC (internal code -6). For more details, run SHOW WARNINGS (1457)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Customer has few legacy functions.

One of the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
mysqldump --no-data --routines --events --triggers --force --databases tdsdbsgowner > dump.sql
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Undeclared variable: DBPAY_DRAWING_AMT (1327)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Susmeet Khaire made changes - 2023-04-21 00:28

Description

Customer has few legacy functions.

One of the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
mysqldump --no-data --routines --events --triggers --force --databases tdsdbsgowner > dump.sql
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Undeclared variable: DBPAY_DRAWING_AMT (1327)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Customer has few legacy functions.

One of the function has some syntax error.
But more importantly customer is unable to take a dump of the function even with --force.

{code:java}
mysqldump --no-data --routines --events --triggers --force --databases xxxx> dump.sql
mysqldump: Couldn't execute 'SHOW CREATE FUNCTION `FF1`': Undeclared variable: DBPAY_DRAWING_AMT (1327)
{code}

Force option is supposed to ignore the error, add a comment in the dump file and move on to the next object.
This doesnt happen for this particular function.
But the behaviour can be observed for "Views with missing tables" errors.

Daniel Black added a comment - 2023-04-21 02:35

reproduced with:

MariaDB [mysql]> create function bob() returns int return 1;

MariaDB [mysql]> update proc set body='return no_such_var' where name='bob';

Query OK, 1 row affected (0.001 sec)

Rows matched: 1  Changed: 1  Warnings: 0

MariaDB [mysql]> show create function bob;

ERROR 1327 (42000): Undeclared variable: no_such_var

MariaDB [mysql]> select bob();

ERROR 1457 (HY000): Failed to load routine mysql.bob (internal code -6). For more details, run SHOW WARNINGS

MariaDB [mysql]> show warnings;

+-------+------+------------------------------------------------------------------------------------------+

| Level | Code | Message                                                                                  |

+-------+------+------------------------------------------------------------------------------------------+

| Error | 1327 | Undeclared variable: no_such_var                                                         |

| Error | 1457 | Failed to load routine mysql.bob (internal code -6). For more details, run SHOW WARNINGS |

+-------+------+------------------------------------------------------------------------------------------+

2 rows in set (0.000 sec)

I suppose it would be more consistent to treat events and triggers the same way during mariadb-dump too.

Daniel Black added a comment - 2023-04-21 02:35 reproduced with: MariaDB [mysql]> create function bob() returns int return 1; MariaDB [mysql]> update proc set body= 'return no_such_var' where name = 'bob' ; Query OK, 1 row affected (0.001 sec) Rows matched: 1 Changed: 1 Warnings: 0 MariaDB [mysql]> show create function bob; ERROR 1327 (42000): Undeclared variable: no_such_var MariaDB [mysql]> select bob(); ERROR 1457 (HY000): Failed to load routine mysql.bob (internal code -6). For more details, run SHOW WARNINGS MariaDB [mysql]> show warnings; + -------+------+------------------------------------------------------------------------------------------+ | Level | Code | Message | + -------+------+------------------------------------------------------------------------------------------+ | Error | 1327 | Undeclared variable: no_such_var | | Error | 1457 | Failed to load routine mysql.bob (internal code -6). For more details, run SHOW WARNINGS | + -------+------+------------------------------------------------------------------------------------------+ 2 rows in set (0.000 sec) I suppose it would be more consistent to treat events and triggers the same way during mariadb-dump too.

Julien Fritsch made changes - 2023-04-21 06:55

Issue Type

Task [ 3 ]

Bug [ 1 ]

Julien Fritsch made changes - 2023-04-21 06:56

Labels

mysqldump

Julien Fritsch made changes - 2023-04-21 06:59

Assignee

Sergei Golubchik [ serg ]

Daniel Black made changes - 2023-04-21 07:10

Affects Version/s		10.6.12 [ 28513 ]
Affects Version/s		10.5 [ 23123 ]

Daniel Black made changes - 2023-04-21 07:10

Component/s

Scripts & Clients [ 11002 ]

Daniel Black made changes - 2023-04-21 08:10

Assignee

Sergei Golubchik [ serg ]

Daniel Black [ danblack ]

Daniel Black added a comment - 2023-04-21 23:51

It occurs to me we could just removing the validation of the function in SHOW CREATE FUNCTION? This would make it equivalent to triggers and events who's SHOW SQL doesn't validate the function.

Any recommendation serg?

Daniel Black added a comment - 2023-04-21 23:51 It occurs to me we could just removing the validation of the function in SHOW CREATE FUNCTION ? This would make it equivalent to triggers and events who's SHOW SQL doesn't validate the function. Any recommendation serg ?

Julien Fritsch made changes - 2023-04-22 06:52

Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.6 [ 24028 ]

Julien Fritsch made changes - 2023-04-24 07:01

Fix Version/s

10.4 [ 22408 ]

Sergei Golubchik added a comment - 2023-04-24 08:49

danblack, I think just making --force to continue over errors should be enough here. If someone would want to include invalid routines into the dump it could be easily achieved by dumping mysql.proc and not using --routines

Sergei Golubchik added a comment - 2023-04-24 08:49 danblack , I think just making --force to continue over errors should be enough here. If someone would want to include invalid routines into the dump it could be easily achieved by dumping mysql.proc and not using --routines

Julien Fritsch made changes - 2023-05-26 14:32

Priority

Major [ 3 ]

Critical [ 2 ]

Julien Fritsch made changes - 2023-06-02 09:55

Status

Open [ 1 ]

Confirmed [ 10101 ]

Sergei Golubchik made changes - 2023-07-31 15:04

Assignee

Daniel Black [ danblack ]

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2023-07-31 15:37

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Sergei Golubchik made changes - 2023-07-31 15:56

Fix Version/s

10.4 [ 22408 ]

Sergei Golubchik made changes - 2023-07-31 18:41

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Sergei Golubchik made changes - 2023-07-31 18:41

Status

Stalled [ 10000 ]

In Testing [ 10301 ]

Sergei Golubchik made changes - 2023-07-31 22:04

Fix Version/s		10.4.31 [ 29010 ]
Fix Version/s		10.5.22 [ 29011 ]
Fix Version/s		10.6.15 [ 29013 ]
Fix Version/s		10.9.8 [ 29015 ]
Fix Version/s		10.10.6 [ 29017 ]
Fix Version/s		10.11.5 [ 29019 ]
Fix Version/s		11.1.2 [ 28921 ]
Fix Version/s		11.2.1 [ 29034 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Resolution		Fixed [ 1 ]
Status	In Testing [ 10301 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2023-07-31 22:05

Fix Version/s

11.0.3 [ 28920 ]

Jira Automation (IT) made changes - 2024-07-04 01:12

Zendesk Related Tickets

157168

MariaDB Server

mysqldump --force doesn't ignore error as it should

Details

Description

Attachments

Activity

People

Dates

Git Integration