Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31057

rocksdb does not compile with gcc-13

Details

    Description

      Issue is the missing includes (cstdint)

      This (tweaked) upstream patch https://github.com/facebook/rocksdb/pull/8893 is required to build rocksdb with gcc-13-20230409

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-30610 Update RocksDB to the latest upstream version

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black added a comment -

            hi, I don't see a patch yet.

            Happy to include it, preferably as a pull request on https://github.com/MariaDB/server/pulls.

            Or is the change within the rocksdb submodule?

            danblack Daniel Black added a comment - hi, I don't see a patch yet. Happy to include it, preferably as a pull request on https://github.com/MariaDB/server/pulls . Or is the change within the rocksdb submodule?
            heitbaum Rudi Heitbaum added a comment -

            Hi Daniel,- a change in the submodule - the current rocksdb submodule is between the 6.8 and 6.8.1 releases. It looks like the upstream patch was added in 6.25.1. https://github.com/facebook/rocksdb/commit/bda8d93ba95f34aa91ae8578fe7d3454f3324f6a

            heitbaum Rudi Heitbaum added a comment - Hi Daniel,- a change in the submodule - the current rocksdb submodule is between the 6.8 and 6.8.1 releases. It looks like the upstream patch was added in 6.25.1. https://github.com/facebook/rocksdb/commit/bda8d93ba95f34aa91ae8578fe7d3454f3324f6a
            danblack Daniel Black added a comment - - edited

            Thanks heitbaum for checking. Linking this and others to the MDEV-30610 submodule update. As you can see from the task there are significant other things that need to change at the same time, but with hopefully the right community support/effort this can be made to happen somehow (suggestions welcome, to my email daniel@mariadb.org).

            danblack Daniel Black added a comment - - edited Thanks heitbaum for checking. Linking this and others to the MDEV-30610 submodule update. As you can see from the task there are significant other things that need to change at the same time, but with hopefully the right community support/effort this can be made to happen somehow (suggestions welcome, to my email daniel@mariadb.org).
            heitbaum Rudi Heitbaum added a comment -

            Sergei - thanks for the patch. All tested successfully.

            heitbaum Rudi Heitbaum added a comment - Sergei - thanks for the patch. All tested successfully.

            People

              serg Sergei Golubchik
              heitbaum Rudi Heitbaum
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.