[MDEV-31057] rocksdb does not compile with gcc-13 Created: 2023-04-14 Updated: 2023-08-17 Resolved: 2023-05-04 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - RocksDB |
| Affects Version/s: | 10.11.2 |
| Fix Version/s: | 10.11.3, 10.4.29, 10.5.20, 10.6.13, 10.8.8, 10.9.6, 10.10.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Rudi Heitbaum | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | upstream | ||
| Environment: |
Linux with gcc-13 |
||
| Issue Links: |
|
||||||||
| Description |
|
Issue is the missing includes (cstdint) This (tweaked) upstream patch https://github.com/facebook/rocksdb/pull/8893 is required to build rocksdb with gcc-13-20230409 |
| Comments |
| Comment by Daniel Black [ 2023-04-14 ] |
|
hi, I don't see a patch yet. Happy to include it, preferably as a pull request on https://github.com/MariaDB/server/pulls. Or is the change within the rocksdb submodule? |
| Comment by Rudi Heitbaum [ 2023-04-15 ] |
|
Hi Daniel,- a change in the submodule - the current rocksdb submodule is between the 6.8 and 6.8.1 releases. It looks like the upstream patch was added in 6.25.1. https://github.com/facebook/rocksdb/commit/bda8d93ba95f34aa91ae8578fe7d3454f3324f6a |
| Comment by Daniel Black [ 2023-04-16 ] |
|
Thanks heitbaum for checking. Linking this and others to the MDEV-30610 submodule update. As you can see from the task there are significant other things that need to change at the same time, but with hopefully the right community support/effort this can be made to happen somehow (suggestions welcome, to my email daniel@mariadb.org). |
| Comment by Rudi Heitbaum [ 2023-05-05 ] |
|
Sergei - thanks for the patch. All tested successfully. |