Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30946

Index usage for DATE(datetime_column) = const does not work for DELETE and UPDATE

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 11.1(EOL)
    • 11.1.1
    • Optimizer
    • None

    Description

      Expected that index usage for like "DATE(col) = const" to "col BETWEEN concat(const, ' 00:00:00') AND concat(const, ' 23:59:59')" is the same for SELECT, UPDATE and DELETE, but it works only for SELECT.
      Example test:

      create table t1 (pk int primary key, a datetime, c int, key(a));
       
      INSERT INTO t1 (pk,a,c) VALUES (1,'2009-11-29 13:43:32', 2);
      INSERT INTO t1 (pk,a,c) VALUES (2,'2009-11-29 03:23:32', 2);
      INSERT INTO t1 (pk,a,c) VALUES (3,'2009-10-16 05:56:32', 2);
      INSERT INTO t1 (pk,a,c) VALUES (4,'2010-11-29 13:43:32', 2);
      INSERT INTO t1 (pk,a,c) VALUES (5,'2010-10-16 05:56:32', 2);
      INSERT INTO t1 (pk,a,c) VALUES (6,'2011-11-29 13:43:32', 2);
      INSERT INTO t1 (pk,a,c) VALUES (7,'2012-10-16 05:56:32', 2);
       
      explain format=json  select * from t1 where year(a) = 2010;
      explain format=json  update t1 set c = 0 where year(a) = 2010;
      explain format=json  delete from t1 where year(a) = 2010;
       
      drop table t1;
      

      Actual result:

      explain format=json  select * from t1 where year(a) = 2010;
      EXPLAIN
      {
        "query_block": {
          "select_id": 1,
          "cost": 0.003808422,
          "nested_loop": [
            {
              "table": {
                "table_name": "t1",
                "access_type": "range",
                "possible_keys": ["a"],
                "key": "a",
                "key_length": "6",
                "used_key_parts": ["a"],
                "loops": 1,
                "rows": 2,
                "cost": 0.003808422,
                "filtered": 100,
                "index_condition": "t1.a between '2010-01-01 00:00:00' and '2010-12-31 23:59:59'"
              }
            }
          ]
        }
      }
      explain format=json  update t1 set c = 0 where year(a) = 2010;
      EXPLAIN
      {
        "query_block": {
          "select_id": 1,
          "table": {
            "update": 1,
            "table_name": "t1",
            "access_type": "ALL",
            "rows": 7,
            "attached_condition": "year(t1.a) = 2010"
          }
        }
      }
      explain format=json  delete from t1 where year(a) = 2010;
      EXPLAIN
      {
        "query_block": {
          "select_id": 1,
          "table": {
            "delete": 1,
            "table_name": "t1",
            "access_type": "ALL",
            "rows": 7,
            "attached_condition": "year(t1.a) = 2010"
          }
        }
      }
      

      Attachments

        Issue Links

          Activity

            lstartseva Lena Startseva created issue -
            lstartseva Lena Startseva made changes -
            Field Original Value New Value
            lstartseva Lena Startseva made changes -
            Assignee Oleg Smirnov [ JIRAUSER50405 ]
            lstartseva Lena Startseva made changes -
            lstartseva Lena Startseva made changes -
            oleg.smirnov Oleg Smirnov made changes -
            Fix Version/s 11.1 [ 28549 ]
            oleg.smirnov Oleg Smirnov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            oleg.smirnov Oleg Smirnov added a comment -

            The fix is pushed to preview-11.1-mdev-8320. psergei, please review.

            oleg.smirnov Oleg Smirnov added a comment - The fix is pushed to preview-11.1-mdev-8320 . psergei , please review.
            oleg.smirnov Oleg Smirnov made changes -
            Assignee Oleg Smirnov [ JIRAUSER50405 ] Sergei Petrunia [ psergey ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            psergei Sergei Petrunia added a comment - https://lists.launchpad.net/maria-developers/msg13311.html review input
            psergei Sergei Petrunia made changes -
            Assignee Sergei Petrunia [ psergey ] Oleg Smirnov [ JIRAUSER50405 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            oleg.smirnov Oleg Smirnov made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            oleg.smirnov Oleg Smirnov added a comment -

            Fixed, pushed:

            commit 799c63ee15068e92eb1a8d1c4a7103c7c5f4855a (HEAD -> preview-11.1-mdev-8320, origin/preview-11.1-mdev-8320)
            Author: Oleg Smirnov <olernov@gmail.com>
            Date:   Thu Apr 13 18:35:57 2023 +0700
             
                MDEV-8320 Place date conditions transformation before partition pruning
                
                This allows partition pruning to use date conditions
            

            There now 5 commits in the branch, should I squash them?

            oleg.smirnov Oleg Smirnov added a comment - Fixed, pushed: commit 799c63ee15068e92eb1a8d1c4a7103c7c5f4855a (HEAD -> preview-11.1-mdev-8320, origin/preview-11.1-mdev-8320) Author: Oleg Smirnov <olernov@gmail.com> Date: Thu Apr 13 18:35:57 2023 +0700   MDEV-8320 Place date conditions transformation before partition pruning This allows partition pruning to use date conditions There now 5 commits in the branch, should I squash them?
            oleg.smirnov Oleg Smirnov made changes -
            Assignee Oleg Smirnov [ JIRAUSER50405 ] Sergei Petrunia [ psergey ]
            Status In Progress [ 3 ] In Review [ 10002 ]

            The last patch is ok to push.

            psergei Sergei Petrunia added a comment - The last patch is ok to push.
            psergei Sergei Petrunia made changes -
            Status In Review [ 10002 ] Stalled [ 10000 ]
            psergei Sergei Petrunia made changes -
            Status Stalled [ 10000 ] In Testing [ 10301 ]
            psergei Sergei Petrunia made changes -
            Assignee Sergei Petrunia [ psergey ] Lena Startseva [ JIRAUSER50478 ]

            Testing done. Ok to push.

            lstartseva Lena Startseva added a comment - Testing done. Ok to push.
            lstartseva Lena Startseva made changes -
            Status In Testing [ 10301 ] Stalled [ 10000 ]
            lstartseva Lena Startseva made changes -
            Assignee Lena Startseva [ JIRAUSER50478 ] Oleg Smirnov [ JIRAUSER50405 ]
            oleg.smirnov Oleg Smirnov added a comment -

            Pushed to 11.1

            oleg.smirnov Oleg Smirnov added a comment - Pushed to 11.1
            oleg.smirnov Oleg Smirnov made changes -
            Fix Version/s 11.1.1 [ 28704 ]
            Fix Version/s 11.1 [ 28549 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]

            People

              oleg.smirnov Oleg Smirnov
              lstartseva Lena Startseva
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.