Details
-
Task
-
Status: Open (View Workflow)
-
Major
-
Resolution: Unresolved
-
None
Description
MySQL 8 has the RESTART statement. It would be useful to add to MariaDB for compatibility purposes, and is useful in its own right as a relative of the SHUTDOWN statement.
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
- is part of
-
-
- Open
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link | This issue is part of MDEV-28906 [ MDEV-28906 ] |
| Comment | [ Should a replica be restarted as well? ] |
| Labels | compat80 | beginner-friendly compat80 |
Syntax is like SHUTDOWN. So it also supports WAIT FOR ALL SLAVES. It will exit with status code 16 so that monitoring/parent process can detect a restart request. Code logic checks to see if MARIADBD_PARENT_PID env is set and corresponding process is alive (linux only) before shutdown. It is compatible with mysql RESTART except that the name of the env has MARIADBD_ as the prefix instead of MYSQLD_.
Could you implement restart completely within the server executable, why does it need support from the calling process?
| Attachment | MDEV-30813.patch [ 72791 ] |
So, two approaches. Simply exit with a special return code or exec itself instead.
Pro exit:
- MySQL and MaxScale do it this way
- allows to measure the uptime since the last restart
- restores resources better (environment and file descriptors, although the server uses O_CLOEXEC anyway)
Pro exec:
- just works, on itself, does not require support in external tools (e.g. mariadbd-safe, systemd, or k8s)
- doesn't restart the container
| Link |
This issue is duplicated by |
Should a replica be restarted as well?